You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ma...@apache.org on 2020/04/23 16:26:22 UTC
[incubator-pinot] branch s3-fix updated (9a02dc0 -> 35b00ad)
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a change to branch s3-fix
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 9a02dc0 Disable test.
new 35b00ad Disable S3MockListner in S3PinotFSTest.
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (9a02dc0)
\
N -- N -- N refs/heads/s3-fix (35b00ad)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../pinot/plugin/filesystem/S3PinotFSTest.java | 50 ++++++++++------------
1 file changed, 23 insertions(+), 27 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[incubator-pinot] 01/01: Disable S3MockListner in S3PinotFSTest.
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch s3-fix
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 35b00adae16e5c3eaa70019d045f0a950daaf6cd
Author: Mayank Shrivastava <ms...@linkedin.com>
AuthorDate: Thu Apr 23 09:23:50 2020 -0700
Disable S3MockListner in S3PinotFSTest.
We have been running into build failures with this test. Disabling the
test did not help as the failure was actually coming from the S3MockListner
that tries to start S3Mock (and fails with port already in use). Given that
there is no api to choose port to start S3Mock at, we are temporarily disabling
the test and unregistering this listener.
---
.../test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java b/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
index 5f173f3..421ea68 100644
--- a/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
+++ b/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
@@ -31,7 +31,6 @@ import org.apache.commons.io.IOUtils;
import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
-import org.testng.annotations.Listeners;
import org.testng.annotations.Test;
import software.amazon.awssdk.core.sync.RequestBody;
import software.amazon.awssdk.services.s3.S3Client;
@@ -42,7 +41,7 @@ import software.amazon.awssdk.services.s3.model.S3Object;
@Test(enabled = false)
-@Listeners(com.adobe.testing.s3mock.testng.S3MockListener.class)
+//@Listeners(com.adobe.testing.s3mock.testng.S3MockListener.class)
public class S3PinotFSTest {
final String DELIMITER = "/";
S3PinotFS _s3PinotFS;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org