You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/08/07 21:11:47 UTC
[kudu-CR] python: get new pandas dependency working on Python 2.6
Hello Andrew Wong, Jordan Birdsell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11149
to review the following change.
Change subject: python: get new pandas dependency working on Python 2.6
......................................................................
python: get new pandas dependency working on Python 2.6
pandas 0.18 dropped support for Python 2.6, so we need to downgrade our
dependency. Moreover, if we don't explicitly install a 2.6-compatible
version of numpy, we'll get the newest one courtesy of the pandas
installation.
Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
---
M build-support/jenkins/build-and-test.sh
M python/requirements.txt
M python/setup.py
3 files changed, 28 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/11149/1
--
To view, visit http://gerrit.cloudera.org:8080/11149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
[kudu-CR] python: get new pandas dependency working on Python 2.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11149 )
Change subject: python: get new pandas dependency working on Python 2.6
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/11149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 07 Aug 2018 22:07:31 +0000
Gerrit-HasComments: No
[kudu-CR] python: get new pandas dependency working on Python 2.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11149 )
Change subject: python: get new pandas dependency working on Python 2.6
......................................................................
python: get new pandas dependency working on Python 2.6
pandas 0.18 dropped support for Python 2.6, so we need to downgrade our
dependency. Moreover, if we don't explicitly install a 2.6-compatible
version of numpy, we'll get the newest one courtesy of the pandas
installation.
Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Reviewed-on: http://gerrit.cloudera.org:8080/11149
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
M python/requirements.txt
M python/setup.py
3 files changed, 28 insertions(+), 5 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] python: get new pandas dependency working on Python 2.6
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11149 )
Change subject: python: get new pandas dependency working on Python 2.6
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 07 Aug 2018 23:58:50 +0000
Gerrit-HasComments: No
[kudu-CR] python: get new pandas dependency working on Python 2.6
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11149 )
Change subject: python: get new pandas dependency working on Python 2.6
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11149/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11149/1//COMMIT_MSG@11
PS1, Line 11: courtesy of the pandas
: installation
To clarify, pip would install pandas 0.18 but numpy ++1.12, leading to the incompatibility? I'm surprised pip doesn't take into account the python version?
http://gerrit.cloudera.org:8080/#/c/11149/1/python/requirements.txt
File python/requirements.txt:
http://gerrit.cloudera.org:8080/#/c/11149/1/python/requirements.txt@11
PS1, Line 11: 0.19
0.18, right?
http://gerrit.cloudera.org:8080/#/c/11149/1/python/setup.py
File python/setup.py:
http://gerrit.cloudera.org:8080/#/c/11149/1/python/setup.py@197
PS1, Line 197: 0.19
0.18 here too
--
To view, visit http://gerrit.cloudera.org:8080/11149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 07 Aug 2018 21:40:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] python: get new pandas dependency working on Python 2.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11149 )
Change subject: python: get new pandas dependency working on Python 2.6
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11149/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11149/1//COMMIT_MSG@11
PS1, Line 11: courtesy of the pandas
: installation
> To clarify, pip would install pandas 0.18 but numpy ++1.12, leading to the
That's correct. The problem is that pandas expresses a 'numpy >=1.7.0' dependency, which pip can (and does) satisfy using the latest numpy.
pip does support environment markers [1] to isolate particular dependencies to things like Python versions, but not all versions of pip support that. You can read more about it in commit 3d734055c.
1. https://www.python.org/dev/peps/pep-0508/#environment-markers
http://gerrit.cloudera.org:8080/#/c/11149/1/python/requirements.txt
File python/requirements.txt:
http://gerrit.cloudera.org:8080/#/c/11149/1/python/requirements.txt@11
PS1, Line 11: 0.19
> 0.18, right?
Whoops, yes.
http://gerrit.cloudera.org:8080/#/c/11149/1/python/setup.py
File python/setup.py:
http://gerrit.cloudera.org:8080/#/c/11149/1/python/setup.py@197
PS1, Line 197: 0.19
> 0.18 here too
Done
--
To view, visit http://gerrit.cloudera.org:8080/11149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 22:22:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] python: get new pandas dependency working on Python 2.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Andrew Wong, Jordan Birdsell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11149
to look at the new patch set (#2).
Change subject: python: get new pandas dependency working on Python 2.6
......................................................................
python: get new pandas dependency working on Python 2.6
pandas 0.18 dropped support for Python 2.6, so we need to downgrade our
dependency. Moreover, if we don't explicitly install a 2.6-compatible
version of numpy, we'll get the newest one courtesy of the pandas
installation.
Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
---
M build-support/jenkins/build-and-test.sh
M python/requirements.txt
M python/setup.py
3 files changed, 28 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/11149/2
--
To view, visit http://gerrit.cloudera.org:8080/11149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
[kudu-CR] python: get new pandas dependency working on Python 2.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11149 )
Change subject: python: get new pandas dependency working on Python 2.6
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I18dc108ffbe18c74167f6c761d4194293eae76db
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>