[jira] [Commented] (HBASE-9562) Make HLogPE run against configured FS

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850988#comment-13850988 ] 

Enis Soztutar commented on HBASE-9562:
--------------------------------------

Added 0.96.1 as fixVersion as well. This was confusing since the main patch went into 0.96.0, vs the addendum went into 0.96.1. Can we please refrain from that in the future. 

> Make HLogPE run against configured FS
> -------------------------------------
>
>                 Key: HBASE-9562
>                 URL: https://issues.apache.org/jira/browse/HBASE-9562
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance, wal
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.96.0, 0.96.1
>
>         Attachments: 9562.txt, HBASE-9562-addendum.patch
>
>
> HLogPE will not pick up the configured fs from *.xml files; always goes against localfs
> Simple patch:
> {code}
> diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvalu
> index 9c07046..f73258b 100644
> --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
> +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
> @@ -47,6 +47,7 @@ import org.apache.hadoop.hbase.regionserver.wal.HLog.Entry;
>  import org.apache.hadoop.hbase.util.Bytes;
>  import org.apache.hadoop.util.Tool;
>  import org.apache.hadoop.util.ToolRunner;
> +import org.apache.hadoop.hbase.HConstants;
>  /**
>   * This class runs performance benchmarks for {@link HLog}.
> @@ -170,8 +171,12 @@ public final class HLogPerformanceEvaluation extends Configured implements Tool
>      }
>      // Run HLog Performance Evaluation
> +    // First set the fs from configs.  Do it for both configs in case we
> +    // are on hadoop1
> +    getConf().set("fs.default.name", getConf().get(HConstants.HBASE_DIR));
> +    getConf().set("fs.defaultFS", getConf().get(HConstants.HBASE_DIR));
>      FileSystem fs = FileSystem.get(getConf());
> -    LOG.info("" + fs);
> +    LOG.info("FileSystem: " + fs);
>      try {
>        if (rootRegionDir == null) {
>          rootRegionDir = TEST_UTIL.getDataTestDir("HLogPerformanceEvaluation");
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)