You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/18 16:15:48 UTC

[GitHub] [skywalking-kubernetes] zalintyre opened a new pull request, #97: Update Elasticsearch chart dependency to 8.5.1

zalintyre opened a new pull request, #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97

   The old version uses an outdated apiVersion for kind: PodDisruptionBudget, which breaks this chart for Kubernetes 1.21 and ongoing.
   
   The following error emerges when using the old Elastic Helm chart: 
   
   ```
   Error: UPGRADE FAILED: resource mapping not found for name: "elasticsearch-master-pdb" namespace: "" from "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
   ```
   
   As you can see, the newer version of the Elastic Helm chart uses some logic to pass the correct apiVersion: https://github.com/elastic/helm-charts/blob/v8.5.1/elasticsearch/templates/poddisruptionbudget.yaml
   
   Kind regards
   Franz


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1321502906

   Closing in favor of https://github.com/apache/skywalking-kubernetes/pull/98


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1320725776

   It also breaks the CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1320845079

   If it is an optional config, we should be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1320992183

   At least, you could use ElasticSearch official helm to deploy it first, then use our helm to connect the existence ElasticSearch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] zalintyre commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
zalintyre commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1320965424

   As the older Elasticsearch Helm template does not run on Kubernetes <= 1.21, I could not deploy Skywalking in our cluster at all. If the postgres backend is not recommended for production, I cannot use that either. 
   
   The update to chart version 8.5.1 was a tryout of mine to get Skywalking running. I would appreciate it very much if you could provide a Skywalking version that can be installed on Kubernetes 1.25.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1320648146

   Hi, ElasticSearch 8.5.1 is not licensed by the Apache 2.0 anymore. That is why we hold the upgrade.
   We expose to connect existing ElasticSearch as you could use any installed version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] zalintyre commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
zalintyre commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1320998806

   > At least, you could use ElasticSearch official helm to deploy it first, then use our helm to connect the existence ElasticSearch.
   
   Thank you for the hint, I will give this a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1320844679

   > Hi, ElasticSearch 8.5.1 is not licensed by the Apache 2.0 anymore. That is why we hold the upgrade.
   > We expose to connect existing ElasticSearch as you could use any installed version.
   
   Hi. We don't ship ES server/client codes here, we don't directly depends on the ES server (8.5.1 is the Helm Chart version), and, ES is not mandatory required (because we now support using a demo postgresql storage too). Is this still a problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #97:
URL: https://github.com/apache/skywalking-kubernetes/pull/97#issuecomment-1320992419

   @kezhenxu94 Could you take a look at the ElasticSearch deployment in our helm to upgrade?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-kubernetes] kezhenxu94 closed pull request #97: Update Elasticsearch chart dependency to 8.5.1

Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed pull request #97: Update Elasticsearch chart dependency to 8.5.1
URL: https://github.com/apache/skywalking-kubernetes/pull/97


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org