[GitHub] [openwhisk] tysonnorris opened a new issue #4672: active activation count for rate limiting is not affected on HTTP response

[GitBox <gi...@apache.org>]

tysonnorris opened a new issue #4672: active activation count for rate limiting is not affected on HTTP response
URL: https://github.com/apache/openwhisk/issues/4672
 
 
   Creating a load test I received 429 rate limiting responses like `'<namespace>' has exceeded its throttle limit, Too many concurrent requests in flight (count: 1600, allowed: 1600).`
   This was unexpected because:
   - the load test operates as 2000 virtual users
   - the concurrentInvocations limit for the namespace is 8000 
   
   ## Environment details:
   
   * local deployment, vagrant, native ubuntu, Mac OS, Bluemix, ...   
   * version of docker, vagrant, ubuntu, ...
   
   ## Steps to reproduce the issue:
   
   1.   set namespace limit for concurrentActivations to 8000
   2.   run a gatling test with blocking requests and 2000 users
   3.   ? may be affected by using cosmosdb store, which can be slow to store activation records
   
   
   ## Provide the expected results and outputs:
   
   Expect that since number of active requests should be 2000 (or less) at any moment, the 8000 limit should be fine. 
   
   
   ## Provide the actual results and outputs:
   
   I received many 429 responses indicating too many concurrent requests.
   
   ## Additional information you deem important:
   * This may be related to using cosmos to store activations
   * I expect similar would happen if log collection is slower than request arrival rate
   
   I'm wondering what is the impact if we move the counter adjustment from`CommonLoadBalancer.processCompletion` into `CommonLoadBalancer.processResult`. From a user perspective, I expect the rate limiting to apply to requests that I have in flight, as opposed to requests that used to be in flight, but are still having logs collected or response records created.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services