[jira] Commented: (SHINDIG-1211) Only show settings menu in sample gadget if there are user editable prefs

["Paul Lindner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770350#action_12770350 ] 

Paul Lindner commented on SHINDIG-1211:
---------------------------------------

I'm having trouble getting this to work -- at least on chrome.

I had to change gadgets.js line 419 from 

  prefs.default to prefs['default']

If I test this gadget:

http://widgets.nytimes.com/packages/html/igoogle/topstories.xml

I am able to see the setting link, however making any change results in a blank gadget and if I press reload the settings are not retained.


Let me know if there's a better gadget to test with.. 

Thanks!
Paul

> Only show settings menu in sample gadget if there are user editable prefs
> -------------------------------------------------------------------------
>
>                 Key: SHINDIG-1211
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1211
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Javascript 
>            Reporter: Benjamin McCann
>         Attachments: shindig_javascript_container_gadget.js.patch, shindig_javascript_samplecontainer_samplecontainer.js.patch
>
>
> Right now, the settings option is always displayed.  Instead, it would be better to make this like iGoogle where the settings menu is displayed only if there are non-hidden prefs.  In order to accomplish this, we need to initialize the gadget with the preference information and the gadget needs to store the preference object instead of just the preference name/value so that we have access to the preference type.  This will also make it easier to implement a gadget prefs UI as described in SHINDIG-1188 since that would also require access to the preference type.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.