You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2023/11/17 15:48:06 UTC

Re: [PR] fix: Without the capital letter, you can't find the translation [superset]

sfirke commented on PR #26010:
URL: https://github.com/apache/superset/pull/26010#issuecomment-1816666428

   It looks like all of the other languages have lower case ([example](https://github.com/apache/superset/blob/bece2ea3e4b9979f3f45f63aa490f499095c7078/superset/translations/sl/LC_MESSAGES/messages.json#L5415)), which matches the base set for translation.  French has uppercase and it's not matching.  Do you agree the French should be changed to lowercase?  I worry that this PR would fix French and break all of the other languages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org