You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ChugR <gi...@git.apache.org> on 2016/10/04 14:47:24 UTC
[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...
GitHub user ChugR opened a pull request:
https://github.com/apache/qpid-dispatch/pull/106
DISPATCH-451: Configurable settings for session capacity and max sessions
This patch allows listener and connector settings for session capacity and for max sessions.
It does _not_ allow a setting for max-message-size. Proton does not provide an interface for changing max message size. This issue is tracked at [PROTON-1311](https://issues.apache.org/jira/browse/PROTON-1311)
Work is progressing on self tests for this feature. Proton python and wrapper interfaces tend to hide sessions and make finding session state difficult.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChugR/qpid-dispatch crolke-DISPATCH-451
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 5f4e4a6f2a0dc326bf51823036ab8e6bad9df063
Author: Chuck Rolke <cr...@redhat.com>
Date: 2016-10-03T17:48:52Z
DISPATCH-451: Allow configurable maxSessions and maxSessionWindow
commit c248a34f3d2da46bb7e7e67ccbd04e2340b69f15
Author: Chuck Rolke <cr...@redhat.com>
Date: 2016-10-03T18:37:40Z
DISPATCH-451: Describe policy setting priority over listener/connector setting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...
Posted by ChugR <gi...@git.apache.org>.
Github user ChugR commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/106#discussion_r81838943
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
uint32_t max_frame_size;
/**
+ * The max_sessions value is the number of sessions allowed on the Connection.
+ * This value minus one is the Open performative channel-max setting.
+ */
+ uint32_t max_sessions;
+
+ /**
+ * The max_session_window value is the maximum number of outstanding octets that are
--- End diff --
Good suggestion. The setting down to proton would be <this setting value> * max-frame-size octets.
There is an identical setting in policy that operates this way, too. Again, they ought to be the same either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/106#discussion_r81817075
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
uint32_t max_frame_size;
/**
+ * The max_sessions value is the number of sessions allowed on the Connection.
+ * This value minus one is the Open performative channel-max setting.
+ */
+ uint32_t max_sessions;
--- End diff --
What will be do with the value 0? Should we use channel_max to avoid this question?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...
Posted by ChugR <gi...@git.apache.org>.
Github user ChugR commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/106#discussion_r81838905
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
uint32_t max_frame_size;
/**
+ * The max_sessions value is the number of sessions allowed on the Connection.
+ * This value minus one is the Open performative channel-max setting.
+ */
+ uint32_t max_sessions;
--- End diff --
There should be a comment that says if you specify zero then you get the default number. Using channel_max is awkward in its own way: if the setting is 1 then you get 2.
There is an identical setting in policy that already used the 1..N numbering (and not 0..N-1). They ought to be the same either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/106#discussion_r81816919
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
uint32_t max_frame_size;
/**
+ * The max_sessions value is the number of sessions allowed on the Connection.
+ * This value minus one is the Open performative channel-max setting.
+ */
+ uint32_t max_sessions;
+
+ /**
+ * The max_session_window value is the maximum number of outstanding octets that are
--- End diff --
Might it be easier to explain this if the units were frames instead of octets?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org