You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/14 01:33:29 UTC
[GitHub] [spark] ulysses-you opened a new pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tupe throw NPE if fields exist no foldable null value
ulysses-you opened a new pull request #34279:
URL: https://github.com/apache/spark/pull/34279
backport https://github.com/apache/spark/pull/34268 for branch-3.0
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Wrap `expr.eval(input)` with Option in `json_tuple`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
If json_tuple exists no foldable null field, Spark would throw NPE during eval field.toString.
e.g. the query will fail with:
```SQL
SELECT json_tuple('{"a":"1"}', if(c1 < 1, null, 'a')) FROM ( SELECT rand() AS c1 );
```
```
Caused by: java.lang.NullPointerException
at org.apache.spark.sql.catalyst.expressions.JsonTuple.$anonfun$parseRow$2(jsonExpressions.scala:435)
at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:286)
at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
at scala.collection.TraversableLike.map(TraversableLike.scala:286)
at scala.collection.TraversableLike.map$(TraversableLike.scala:279)
at scala.collection.AbstractTraversable.map(Traversable.scala:108)
at org.apache.spark.sql.catalyst.expressions.JsonTuple.parseRow(jsonExpressions.scala:435)
at org.apache.spark.sql.catalyst.expressions.JsonTuple.$anonfun$eval$6(jsonExpressions.scala:413)
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, bug fix.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add test in `json-functions.sql`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-942890056
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48704/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-942884452
**[Test build #144224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144224/testReport)** for PR 34279 at commit [`b13360e`](https://github.com/apache/spark/commit/b13360e272914baf8da4537af16dd9fb19445bc3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-942890043
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48704/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-943069026
+1, LGTM. Merging to 3.0.
Thank you, @ulysses-you and @viirya for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-942961500
Probably, the failure in docs is not related to changes:
```
Error in vapply(tags, `[[`, "tag", FUN.VALUE = character(1)) :
values must be type 'character',
but FUN(X[[8]]) result is type 'integer'
Calls: <Anonymous> ... <Anonymous> -> .f -> parse_tags -> parse_description -> vapply
Execution halted
------------------------------------------------
Jekyll 4.2.1 Please append `--trace` to the `build` command
for any additional information or backtrace.
------------------------------------------------
```
Just in case, @HyukjinKwon do you know is it known issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-943008364
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144224/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34279:
URL: https://github.com/apache/spark/pull/34279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-942887665
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48704/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-942884452
**[Test build #144224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144224/testReport)** for PR 34279 at commit [`b13360e`](https://github.com/apache/spark/commit/b13360e272914baf8da4537af16dd9fb19445bc3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-942890056
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48704/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-943006909
**[Test build #144224 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144224/testReport)** for PR 34279 at commit [`b13360e`](https://github.com/apache/spark/commit/b13360e272914baf8da4537af16dd9fb19445bc3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34279: [SPARK-36993][SQL][3.0] Fix json_tuple throw NPE if fields exist no foldable null value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34279:
URL: https://github.com/apache/spark/pull/34279#issuecomment-943008364
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144224/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org