You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/07 22:34:39 UTC

[GitHub] [incubator-superset] ynohat commented on issue #9043: Add support for Cockroach DB

ynohat commented on issue #9043: Add support for Cockroach DB
URL: https://github.com/apache/incubator-superset/pull/9043#issuecomment-583645752
 
 
   @derari thanks a lot for your work on this!
   
   I tried to apply the changes in this PR manually, and it didn't work OOTB with docker-compose. It seems like adding the cockroach dep to `setup.py` is not sufficient, it also needs to be added to `docker/requirements-extra.txt`.
   
   This is first contact with superset for me, so forgive me if this comment is incorrect or misguided!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org