You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/08/02 04:31:49 UTC
[GitHub] [carbondata] manishgupta88 commented on issue #3322:
[CARBONDATA-3482] Fixed NPE in Concurrent query
manishgupta88 commented on issue #3322: [CARBONDATA-3482] Fixed NPE in Concurrent query
URL: https://github.com/apache/carbondata/pull/3322#issuecomment-517544019
LGTM.....Few observations from the PR:
1. If 2 queries are running in parallel only 1 should be loading the bloc/blocklet cache. So I did not get the removal part.
2. If this Singleton class is getting used from Index server on the executor side then we might have to come up with a better design as getting rid of memory leak is difficult in executor.
3. The main reason for storing the primitive type was memory constraint. As long as all the stakeholders are fine this change makes the code more safer.
4. We shall also be publishing the memory usage results which would change now with this PR. We can publish the difference between current and earlier memory usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services