[GitHub] [arrow] kou commented on a diff in pull request #11666: ARROW-14638: [C++][R] Unknown C compiler / ccache on Arch Linux

[GitBox <gi...@apache.org>]

kou commented on code in PR #11666:
URL: https://github.com/apache/arrow/pull/11666#discussion_r855132062


##########
docker-compose.yml:
##########
@@ -55,7 +55,8 @@
 
 version: '3.5'
 
-x-ccache: &ccache
+x-ccache:
+  &ccache

Review Comment:
   Could you revert style changes?



##########
ci/scripts/r_docker_configure.sh:
##########
@@ -42,6 +42,29 @@ else
   apt-get update
 fi
 
+# Enable ccache if requested based on http://dirk.eddelbuettel.com/blog/2017/11/27/
+R_BUILD_CCACHE=`echo $R_BUILD_CCACHE | tr '[:upper:]' '[:lower:]'`
+if [ "$R_BUILD_CCACHE" = "true" ]; then
+  # install ccache
+  $PACKAGE_MANAGER install -y epel-release || true
+  $PACKAGE_MANAGER install -y ccache
+
+  mkdir -p ~/.R
+  echo "VER=
+CCACHE=ccache
+CC=\$(CCACHE) gcc$(VER)

Review Comment:
   It seems that `\` is missing before `$(VER)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org