[GitHub] [incubator-druid] leventov commented on a change in pull request #8165: [Improvement] DataSegment intern improvement (reduce 60% memory consume on coordinator)

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8165: [Improvement] DataSegment intern improvement (reduce 60% memory consume on coordinator)
URL: https://github.com/apache/incubator-druid/pull/8165#discussion_r307832101
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/timeline/DataSegment.java
 ##########
 @@ -87,9 +100,9 @@
   private final Integer binaryVersion;
   private final SegmentId id;
   @Nullable
-  private final Map<String, Object> loadSpec;
-  private final List<String> dimensions;
-  private final List<String> metrics;
+  private volatile Map<String, Object> loadSpec;
 
 Review comment:
   Making `DataSegment` non-immutable was ruled out in this discussion: #7571. Please read it in full. I proposed a solution here: https://github.com/apache/incubator-druid/issues/7571#issuecomment-495288920. Please check if you can implement it in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org