You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Abhishek Nigam <an...@linkedin.com> on 2015/02/25 00:31:37 UTC
Review Request 31385: Patch for KAFKA-1978
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31385/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1978
https://issues.apache.org/jira/browse/KAFKA-1978
Repository: kafka
Description
-------
Fixing configuration for testcase 0131
Diffs
-----
system_test/replication_testsuite/testcase_0131/testcase_0131_properties.json 0324b6f327cb75389f9f851fa3ca744d22a5d915
Diff: https://reviews.apache.org/r/31385/diff/
Testing
-------
Thanks,
Abhishek Nigam
RE: Review Request 31385: Patch for KAFKA-1978
Posted by Abhishek Nigam <an...@linkedin.com.INVALID>.
I added debug information and the reason is that the array size, replicaIdxMsgIdList is 2 but the number of files which are being validated are 3.
2015-02-25 00:53:17,882 - INFO - array size: 2 (kafka_system_test_utils)
2015-02-25 00:53:17,882 - INFO - replicaFactor: 2 (kafka_system_test_utils)
2015-02-25 00:53:17,882 - INFO - replicaIdx: 3 (kafka_system_test_utils)
The code tries to index into the array using index 2 but since the size of the array is only 2 we get array out of bounds exception.
-Abhishek
________________________________
From: Abhishek Nigam
Sent: Wednesday, February 25, 2015 9:43 AM
To: Guozhang Wang; kafka
Subject: RE: Review Request 31385: Patch for KAFKA-1978
2015-02-06 00:51:30,975 - INFO - ======================================================
2015-02-06 00:51:30,975 - INFO - Exception while running test list index out of range
2015-02-06 00:51:30,975 - INFO - ======================================================
Traceback (most recent call last):
File "/mnt/u001/kafka_replication_system_test/system_test/replication_testsuite/replica_basic_test.py", line 434, in runTest
kafka_system_test_utils.validate_simple_consumer_data_matched_across_replicas(self.systemTestEnv, self.testcaseEnv)
File "/mnt/u001/kafka_replication_system_test/system_test/utils/kafka_system_test_utils.py", line 2223, in validate_simple_consumer_data_matched_across_replicas
replicaIdxMsgIdList[replicaIdx - 1][topicPartition] = consumerMsgIdList
IndexError: list index out of range
-Abhishek
________________________________
From: Guozhang Wang [noreply@reviews.apache.org] on behalf of Guozhang Wang [wangguoz@gmail.com]
Sent: Tuesday, February 24, 2015 6:36 PM
To: Abhishek Nigam; Guozhang Wang; kafka
Subject: Re: Review Request 31385: Patch for KAFKA-1978
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31385/
>From the diff file itself it's a bit hard to understand the issue and the solution as well. Could you elaborate on "an out of bounds exception due to mis-configuration" on the ticket?
- Guozhang Wang
On February 24th, 2015, 11:31 p.m. UTC, Abhishek Nigam wrote:
Review request for kafka.
By Abhishek Nigam.
Updated Feb. 24, 2015, 11:31 p.m.
Bugs: KAFKA-1978<https://issues.apache.org/jira/browse/KAFKA-1978>
Repository: kafka
Description
Fixing configuration for testcase 0131
Diffs
* system_test/replication_testsuite/testcase_0131/testcase_0131_properties.json (0324b6f327cb75389f9f851fa3ca744d22a5d915)
View Diff<https://reviews.apache.org/r/31385/diff/>
RE: Review Request 31385: Patch for KAFKA-1978
Posted by Abhishek Nigam <an...@linkedin.com.INVALID>.
2015-02-06 00:51:30,975 - INFO - ======================================================
2015-02-06 00:51:30,975 - INFO - Exception while running test list index out of range
2015-02-06 00:51:30,975 - INFO - ======================================================
Traceback (most recent call last):
File "/mnt/u001/kafka_replication_system_test/system_test/replication_testsuite/replica_basic_test.py", line 434, in runTest
kafka_system_test_utils.validate_simple_consumer_data_matched_across_replicas(self.systemTestEnv, self.testcaseEnv)
File "/mnt/u001/kafka_replication_system_test/system_test/utils/kafka_system_test_utils.py", line 2223, in validate_simple_consumer_data_matched_across_replicas
replicaIdxMsgIdList[replicaIdx - 1][topicPartition] = consumerMsgIdList
IndexError: list index out of range
-Abhishek
________________________________
From: Guozhang Wang [noreply@reviews.apache.org] on behalf of Guozhang Wang [wangguoz@gmail.com]
Sent: Tuesday, February 24, 2015 6:36 PM
To: Abhishek Nigam; Guozhang Wang; kafka
Subject: Re: Review Request 31385: Patch for KAFKA-1978
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31385/
>From the diff file itself it's a bit hard to understand the issue and the solution as well. Could you elaborate on "an out of bounds exception due to mis-configuration" on the ticket?
- Guozhang Wang
On February 24th, 2015, 11:31 p.m. UTC, Abhishek Nigam wrote:
Review request for kafka.
By Abhishek Nigam.
Updated Feb. 24, 2015, 11:31 p.m.
Bugs: KAFKA-1978<https://issues.apache.org/jira/browse/KAFKA-1978>
Repository: kafka
Description
Fixing configuration for testcase 0131
Diffs
* system_test/replication_testsuite/testcase_0131/testcase_0131_properties.json (0324b6f327cb75389f9f851fa3ca744d22a5d915)
View Diff<https://reviews.apache.org/r/31385/diff/>
Re: Review Request 31385: Patch for KAFKA-1978
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31385/#review73963
-----------------------------------------------------------
>From the diff file itself it's a bit hard to understand the issue and the solution as well. Could you elaborate on "an out of bounds exception due to mis-configuration" on the ticket?
- Guozhang Wang
On Feb. 24, 2015, 11:31 p.m., Abhishek Nigam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31385/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 11:31 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1978
> https://issues.apache.org/jira/browse/KAFKA-1978
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Fixing configuration for testcase 0131
>
>
> Diffs
> -----
>
> system_test/replication_testsuite/testcase_0131/testcase_0131_properties.json 0324b6f327cb75389f9f851fa3ca744d22a5d915
>
> Diff: https://reviews.apache.org/r/31385/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abhishek Nigam
>
>