You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Alessandro Presta (JIRA)" <ji...@apache.org> on 2012/11/19 19:31:58 UTC

[jira] [Created] (GIRAPH-433) Vertex#initialize() shouldn

Alessandro Presta created GIRAPH-433:
----------------------------------------

             Summary: Vertex#initialize() shouldn
                 Key: GIRAPH-433
                 URL: https://issues.apache.org/jira/browse/GIRAPH-433
             Project: Giraph
          Issue Type: Bug
            Reporter: Alessandro Presta




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-433) Vertex#initialize() shouldn't be called with null edges

Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alessandro Presta updated GIRAPH-433:
-------------------------------------

    Description: 
VertexResolver calls Vertex#initialize() with edges=null, and this causes problems for implementations that don't check for null (see HashMapVertex).
As we have another initialize() that assumes no edges, that should be called instead.
I'm also removing the null check in EdgeListVertex since a null should never be passed.
    
> Vertex#initialize() shouldn't be called with null edges
> -------------------------------------------------------
>
>                 Key: GIRAPH-433
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-433
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>
> VertexResolver calls Vertex#initialize() with edges=null, and this causes problems for implementations that don't check for null (see HashMapVertex).
> As we have another initialize() that assumes no edges, that should be called instead.
> I'm also removing the null check in EdgeListVertex since a null should never be passed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-433) Vertex#initialize() shouldn't be called with null edges

Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alessandro Presta updated GIRAPH-433:
-------------------------------------

    Assignee: Alessandro Presta
    
> Vertex#initialize() shouldn't be called with null edges
> -------------------------------------------------------
>
>                 Key: GIRAPH-433
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-433
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>
> VertexResolver calls Vertex#initialize() with edges=null, and this causes problems for implementations that don't check for null (see HashMapVertex).
> As we have another initialize() that assumes no edges, that should be called instead.
> I'm also removing the null check in EdgeListVertex since a null should never be passed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-433) Vertex#initialize() shouldn't be called with null edges

Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alessandro Presta updated GIRAPH-433:
-------------------------------------

    Summary: Vertex#initialize() shouldn't be called with null edges  (was: Vertex#initialize() shouldn)
    
> Vertex#initialize() shouldn't be called with null edges
> -------------------------------------------------------
>
>                 Key: GIRAPH-433
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-433
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-433) Vertex#initialize() shouldn't be called with null edges

Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alessandro Presta updated GIRAPH-433:
-------------------------------------

    Attachment: GIRAPH-433.patch

Also fixing some code paths that could lead to NPE in VertexResolver. This class will need a good redesign at some point soon (see GIRAPH-419).
                
> Vertex#initialize() shouldn't be called with null edges
> -------------------------------------------------------
>
>                 Key: GIRAPH-433
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-433
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>         Attachments: GIRAPH-433.patch
>
>
> VertexResolver calls Vertex#initialize() with edges=null, and this causes problems for implementations that don't check for null (see HashMapVertex).
> As we have another initialize() that assumes no edges, that should be called instead.
> I'm also removing the null check in EdgeListVertex since a null should never be passed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira