You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/11/13 23:07:00 UTC
[GitHub] [tinkerpop] rdtr opened a new pull request #1358: HasStep implements configuring
rdtr opened a new pull request #1358:
URL: https://github.com/apache/tinkerpop/pull/1358
As a graph provider, we need `HasStep` followed by `with()` options. Right now `HasStep` doesn't implement `configuring` so we encounter `ClassCastException`.
This commit simply adds a configuring implementation same as other steps like `PropertiesStep`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1358: HasStep implements configuring
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1358:
URL: https://github.com/apache/tinkerpop/pull/1358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] divijvaidya commented on pull request #1358: HasStep implements configuring
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on pull request #1358:
URL: https://github.com/apache/tinkerpop/pull/1358#issuecomment-729278116
> Starting to think about whether Configuring should be a feature of all steps and what refactoring that might mean
+1
As an evolution of the language itself, I am of the opinion that we should provide the ability to add "query hints" using the `with` step to every step in the language. This provides flexibility to the providers to extend the meaning of steps in their own fashion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1358: HasStep implements configuring
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1358:
URL: https://github.com/apache/tinkerpop/pull/1358#issuecomment-729147101
Could you please re-target this pull request to `3.4-dev` branch? I should have noticed that on my previous review...
Starting to think about whether `Configuring` should be a feature of all steps and what refactoring that might mean. There is a JIRA issue somewhere that talks about the use of `Parameters` on many other steps than just the `Mutating` ones. I'll go find that and review a bit. That said, I still think it will be fine if this PR merged just as it is...just going to think on it a bit longer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1358: HasStep implements configuring
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1358:
URL: https://github.com/apache/tinkerpop/pull/1358#issuecomment-727945754
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1358: HasStep implements configuring
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1358:
URL: https://github.com/apache/tinkerpop/pull/1358#issuecomment-729731359
This was the issue I was thinking of:
https://issues.apache.org/jira/browse/TINKERPOP-1329
The comments are a bit tangential to the issue so you can largely stay focused on the description. It does indeed bring up the notion of using `Parameterizing` on filter steps as the next logical place where we would implement that functionality. This is relevant because `Configuring` extends `Parameterizing` and uses the same infrastructure to support it.
Perhaps we consider a broader implementation for 3.5.0 and stick to this more localized changed here in 3.4.x. I feel like I'd need to do some exploratory implementation to see what impacts it would have - just poking around the code isn't enlightening me just now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org