You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2011/08/04 23:13:27 UTC
[jira] [Created] (SOLR-2699) Add SolrInputDocument support to
javabin format
Add SolrInputDocument support to javabin format
-----------------------------------------------
Key: SOLR-2699
URL: https://issues.apache.org/jira/browse/SOLR-2699
Project: Solr
Issue Type: Improvement
Reporter: Yonik Seeley
Priority: Minor
Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2699) Add SolrInputDocument support to
javabin format
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080060#comment-13080060 ]
Yonik Seeley commented on SOLR-2699:
------------------------------------
Yep, good catch. That's important when we're adding more than one doc.
> Add SolrInputDocument support to javabin format
> -----------------------------------------------
>
> Key: SOLR-2699
> URL: https://issues.apache.org/jira/browse/SOLR-2699
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: SOLR-2699.patch, SOLR-2699.patch
>
>
> Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2699) Add SolrInputDocument support to
javabin format
Posted by "Shalin Shekhar Mangar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-2699:
----------------------------------------
Attachment: SOLR-2699-backcompat-fix.patch
Here's a patch which restores backward compatibility.
> Add SolrInputDocument support to javabin format
> -----------------------------------------------
>
> Key: SOLR-2699
> URL: https://issues.apache.org/jira/browse/SOLR-2699
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: SOLR-2699-backcompat-fix.patch, SOLR-2699.patch, SOLR-2699.patch
>
>
> Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-2699) Add SolrInputDocument
support to javabin format
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079863#comment-13079863 ]
Noble Paul edited comment on SOLR-2699 at 8/5/11 9:11 AM:
----------------------------------------------------------
the field name should be written using
writeExternString(inputField.getName())
instead of
writeStr(inputField.getName());
was (Author: noble.paul):
hi the field name should be written using
writeExternString(inputField.getName())
instead of
writeStr(inputField.getName());
> Add SolrInputDocument support to javabin format
> -----------------------------------------------
>
> Key: SOLR-2699
> URL: https://issues.apache.org/jira/browse/SOLR-2699
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: SOLR-2699.patch, SOLR-2699.patch
>
>
> Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2699) Add SolrInputDocument support to
javabin format
Posted by "Shalin Shekhar Mangar (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-2699.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Yonik Seeley
The back compat fix was committed with SOLR-2904.
> Add SolrInputDocument support to javabin format
> -----------------------------------------------
>
> Key: SOLR-2699
> URL: https://issues.apache.org/jira/browse/SOLR-2699
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2699-backcompat-fix.patch, SOLR-2699.patch, SOLR-2699.patch
>
>
> Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2699) Add SolrInputDocument support to
javabin format
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-2699:
-------------------------------
Attachment: SOLR-2699.patch
Here's a draft patch that doesn't work yet (not sure why yet... the JavaBinUpdateCodec related code is a little hard to grok).
Anyway, it seems like we should fix SOLR-1164 at the same time.
> Add SolrInputDocument support to javabin format
> -----------------------------------------------
>
> Key: SOLR-2699
> URL: https://issues.apache.org/jira/browse/SOLR-2699
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: SOLR-2699.patch
>
>
> Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2699) Add SolrInputDocument support to
javabin format
Posted by "Shalin Shekhar Mangar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151182#comment-13151182 ]
Shalin Shekhar Mangar commented on SOLR-2699:
---------------------------------------------
While working on SOLR-1565, I found that this patch was committed to trunk but there is no mention of it in the change log.
One problem with this patch is that it breaks backwards compatibility. A new Solr server should be able to read update requests sent by old clients otherwise upgrading Solr becomes very difficult. An old client will send a SolrInputDocument as a NamedList but the server will fail with a ClassCastException.
> Add SolrInputDocument support to javabin format
> -----------------------------------------------
>
> Key: SOLR-2699
> URL: https://issues.apache.org/jira/browse/SOLR-2699
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: SOLR-2699.patch, SOLR-2699.patch
>
>
> Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2699) Add SolrInputDocument support to
javabin format
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-2699:
-------------------------------
Attachment: SOLR-2699.patch
The culprit was a missing "return" after the serialization of the SolrInputDoc. Tests now pass with this update.
> Add SolrInputDocument support to javabin format
> -----------------------------------------------
>
> Key: SOLR-2699
> URL: https://issues.apache.org/jira/browse/SOLR-2699
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: SOLR-2699.patch, SOLR-2699.patch
>
>
> Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2699) Add SolrInputDocument support to
javabin format
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079863#comment-13079863 ]
Noble Paul commented on SOLR-2699:
----------------------------------
hi the field name should be written using
writeExternString(inputField.getName())
instead of
writeStr(inputField.getName());
> Add SolrInputDocument support to javabin format
> -----------------------------------------------
>
> Key: SOLR-2699
> URL: https://issues.apache.org/jira/browse/SOLR-2699
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: SOLR-2699.patch, SOLR-2699.patch
>
>
> Supporting SolrInputDocument (like SolrDocument is already supported) directly in javabin will make both transaction logging and recovering updates from peers much easier.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org