You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/26 17:26:00 UTC

[jira] [Commented] (GEODE-8458) Rebuild GemFireVersion.properties on build-flag changes

    [ https://issues.apache.org/jira/browse/GEODE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185368#comment-17185368 ] 

ASF GitHub Bot commented on GEODE-8458:
---------------------------------------

rhoughton-pivot opened a new pull request #5480:
URL: https://github.com/apache/geode/pull/5480


   * Rebuilds GemFireVersion.properties on Git repo or property changes
     * version
     * build user
     * java version
     * productName
     * etc
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   - [X] Does `gradlew build` run cleanly?
   
   - [n/a] Have you written or updated unit tests to verify your changes?
   
   - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Rebuild GemFireVersion.properties on build-flag changes
> -------------------------------------------------------
>
>                 Key: GEODE-8458
>                 URL: https://issues.apache.org/jira/browse/GEODE-8458
>             Project: Geode
>          Issue Type: Bug
>          Components: build
>            Reporter: Robert Houghton
>            Priority: Major
>
> GemFireVersion.properties is a resource holding information about the product and build metadata. It is possible to set these values for the first time using Gradle property flags like '-Pversion=1.2.3-build.456'. On subsequent runs, the property file should be re-built if those values have changed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)