You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2012/11/05 22:35:48 UTC
svn commit: r1405969 -
/subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp
Author: julianfoad
Date: Mon Nov 5 21:35:48 2012
New Revision: 1405969
URL: http://svn.apache.org/viewvc?rev=1405969&view=rev
Log:
* subversion/bindings/javahl/native/CopySources.cpp
(array): Simplify, simplify.
Modified:
subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp
Modified: subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp?rev=1405969&r1=1405968&r2=1405969&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp (original)
+++ subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp Mon Nov 5 21:35:48 2012
@@ -143,10 +143,7 @@ CopySources::array(SVN::Pool &pool)
// TODO: Default this to svn_opt_revision_undefined (or HEAD)
Revision rev(jrev);
src->revision = reinterpret_cast<const svn_opt_revision_t *>
- (apr_palloc(p, sizeof(*src->revision)));
- memcpy(const_cast<svn_opt_revision_t *>(src->revision),
- rev.revision(),
- sizeof(*src->revision));
+ (apr_pmemdup(p, rev.revision(), sizeof(*src->revision)));
env->DeleteLocalRef(jrev);
// Extract pegRevision from the copy source.
@@ -164,10 +161,7 @@ CopySources::array(SVN::Pool &pool)
Revision pegRev(jPegRev, true);
src->peg_revision = reinterpret_cast<const svn_opt_revision_t *>
- (apr_palloc(p, sizeof(*src->peg_revision)));
- memcpy(const_cast<svn_opt_revision_t *>(src->peg_revision),
- pegRev.revision(),
- sizeof(*src->peg_revision));
+ (apr_pmemdup(p, pegRev.revision(), sizeof(*src->peg_revision)));
env->DeleteLocalRef(jPegRev);
APR_ARRAY_PUSH(copySources, svn_client_copy_source_t *) = src;