You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "watermelon12138 (via GitHub)" <gi...@apache.org> on 2023/02/28 03:21:43 UTC
[GitHub] [hudi] watermelon12138 opened a new pull request, #8069: [HUDI-5860] Table name supports Chinese and backquote.
watermelon12138 opened a new pull request, #8069:
URL: https://github.com/apache/hudi/pull/8069
### Change Logs
Table name supports Chinese and backquote.
### Impact
Spark sql parser.
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8069: [HUDI-5860] Table name supports Chinese and backquote.
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8069:
URL: https://github.com/apache/hudi/pull/8069#discussion_r1225603000
##########
hudi-spark-datasource/hudi-spark3.3.x/src/main/antlr4/imports/SqlBase.g4:
##########
@@ -1864,7 +1864,7 @@ BIGDECIMAL_LITERAL
;
IDENTIFIER
- : (LETTER | DIGIT | '_')+
+ : (CHINESE | LETTER | DIGIT | '_')+
Review Comment:
Could you also fix other Spark versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8069: [HUDI-5860] Table name supports Chinese and backquote.
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8069:
URL: https://github.com/apache/hudi/pull/8069#issuecomment-1447904780
cc @XuQianJin-Stars for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8069: [HUDI-5860] Table name supports Chinese and backquote.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8069:
URL: https://github.com/apache/hudi/pull/8069#issuecomment-1448384481
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463",
"triggerID" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"triggerType" : "PUSH"
}, {
"hash" : "73ee4363b94ddecf8601da2b6855c59fe44671d1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15473",
"triggerID" : "73ee4363b94ddecf8601da2b6855c59fe44671d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73ee4363b94ddecf8601da2b6855c59fe44671d1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15473)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8069: [HUDI-5860] Table name supports Chinese and backquote.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8069:
URL: https://github.com/apache/hudi/pull/8069#issuecomment-1447725317
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463",
"triggerID" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68331efe272e90818ffdd7e47ccd5b1895fc3619 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8069: [HUDI-5860] Table name supports Chinese and backquote.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8069:
URL: https://github.com/apache/hudi/pull/8069#issuecomment-1447866128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463",
"triggerID" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"triggerType" : "PUSH"
}, {
"hash" : "73ee4363b94ddecf8601da2b6855c59fe44671d1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15473",
"triggerID" : "73ee4363b94ddecf8601da2b6855c59fe44671d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68331efe272e90818ffdd7e47ccd5b1895fc3619 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463)
* 73ee4363b94ddecf8601da2b6855c59fe44671d1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15473)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8069: [HUDI-5860] Table name supports Chinese and backquote.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8069:
URL: https://github.com/apache/hudi/pull/8069#issuecomment-1447855359
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463",
"triggerID" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"triggerType" : "PUSH"
}, {
"hash" : "73ee4363b94ddecf8601da2b6855c59fe44671d1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "73ee4363b94ddecf8601da2b6855c59fe44671d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68331efe272e90818ffdd7e47ccd5b1895fc3619 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463)
* 73ee4363b94ddecf8601da2b6855c59fe44671d1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8069: [HUDI-5860] Table name supports Chinese and backquote.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8069:
URL: https://github.com/apache/hudi/pull/8069#issuecomment-1447528248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463",
"triggerID" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68331efe272e90818ffdd7e47ccd5b1895fc3619 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15463)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8069: [HUDI-5860] Table name supports Chinese and backquote.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8069:
URL: https://github.com/apache/hudi/pull/8069#issuecomment-1447523835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68331efe272e90818ffdd7e47ccd5b1895fc3619",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68331efe272e90818ffdd7e47ccd5b1895fc3619 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org