You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/16 23:07:53 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #25746: Added append_job_name parameter to DataflowTemplatedJobStartOperator

uranusjr commented on code in PR #25746:
URL: https://github.com/apache/airflow/pull/25746#discussion_r947317561


##########
airflow/providers/google/cloud/operators/dataflow.py:
##########
@@ -612,6 +613,7 @@ def __init__(
         environment: Optional[Dict] = None,
         cancel_timeout: Optional[int] = 10 * 60,
         wait_until_finished: Optional[bool] = None,
+        append_job_name: Optional[bool] = True,

Review Comment:
   Why optional? None is not acceptable in DataflowHook.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org