[GitHub] [spark] cloud-fan commented on a change in pull request #29261: [SPARK-32459][SQL] Support WrappedArray as customCollectionCls in MapObjects

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29261:
URL: https://github.com/apache/spark/pull/29261#discussion_r461472555



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -755,6 +755,9 @@ case class MapObjects private(
   }
 
   private lazy val mapElements: Seq[_] => Any = customCollectionCls match {
+    case Some(cls) if classOf[WrappedArray[_]].isAssignableFrom(cls) =>

Review comment:
       does it really work with any sub-class of `WrappedArray`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org