[GitHub] tweise commented on a change in pull request #7672: [FLINK-11568][kinesis] Don't obscure important Kinesis exceptions

[GitBox <gi...@apache.org>]

tweise commented on a change in pull request #7672: [FLINK-11568][kinesis] Don't obscure important Kinesis exceptions
URL: https://github.com/apache/flink/pull/7672#discussion_r257085977
 
 

 ##########
 File path: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/AlwaysThrowsDeserializationSchema.java
 ##########
 @@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.kinesis.testutils;
+
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.core.testutils.OneShotLatch;
+
+import java.io.IOException;
+
+/**
+ * A DeserializationSchema which always throws an exception when the deserialize method is called. Also supports
+ * waiting on a latch until at least one exception has been thrown.
+ */
+public class AlwaysThrowsDeserializationSchema implements DeserializationSchema<String> {
 
 Review comment:
   This class could have probably also been defined nested in the test and some of the boilerplate avoided by extending an existing schema with override for what is relevant here. Just something to keep in mind for future work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services