You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/02/15 09:59:50 UTC

[GitHub] [systemds] Baunsgaard commented on pull request #1531: [SYSTEMDS-2996] countDistinctApprox Builtin function

Baunsgaard commented on pull request #1531:
URL: https://github.com/apache/systemds/pull/1531#issuecomment-1040076671


   > > Implementation wise there is one major thing that is unfortunate in:
   > > src/main/java/org/apache/sysds/runtime/instructions/cp/AggregateUnaryCPInstruction.java
   > 
   > > Where you slice out the individual columns and rows if we aggregate over them, to then use the default counting algorithm. This should preferably be avoided, since the slicing then becomes the dominating part of the execution.
   > 
   > Hi @Baunsgaard , I was thinking about your feedback and I think it makes sense. I would be happy to go ahead and make your recommended changes to the PR, please let me know!
   
   Hi @BACtaki , 
   you are very welcome to give it a go, but if you can wait a couple of days then i will have merged this, and then we can make it another PR?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org