You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/07/26 15:27:06 UTC
[kudu-CR] [docs] Add changing master hostnames workflow
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11058
Change subject: [docs] Add changing master hostnames workflow
......................................................................
[docs] Add changing master hostnames workflow
Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
---
M docs/administration.adoc
1 file changed, 73 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/11058/1
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 27 Jul 2018 10:35:28 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@676
PS1, Line 676: new-master-name-1
> it should always be FQDN, with IPs Kerberos wouldn't work properly by defau
I agree it should be FQDN here (for best practices's sake), and maybe it's better not to talk about IP addresses at all to avoid confusion, indeed.
As for Kerberos-related restrictions, I'm not sure they are relevant for Raft config members, but that's not the point here anyway :)
My point actually was: I didn't see FQDN is mentioned anywhere in the new section. Maybe, it's worth explicitly stating that all those new master names are FQDNs? Not short names, not IPs, not anything else.
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@679
PS1, Line 679: master_addresses
> hostname change shouldn't affect that, unless they switch IP address as wel
Right, that was my point -- if IP addresses changed, I though it would be nice to mention that other flags need to be updated as well.
It seems my wording of '... any custom values ...' were set was confusing, sorry.
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@684
PS1, Line 684: . Start up the masters.
> verification is suggested in a later step
Right, but that was exactly my point here -- if just after migrating masters we can spot an error, that might be better because starting tablet servers takes some time and detecting a problem earlier makes it better localized. Do you think it's not worth it?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@686
PS1, Line 686: Start all of the tablet servers.
> verification is suggested in a later step
Yep, indeed.
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@696
PS1, Line 696:
> Done
All right -- it seems you decided to use short names in both cases. Then, maybe mention somewhere that those are supposed to be FQDNs?
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 27 Jul 2018 22:02:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11058
to look at the new patch set (#4).
Change subject: [docs] Add changing master hostnames workflow
......................................................................
[docs] Add changing master hostnames workflow
Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
---
M docs/administration.adoc
1 file changed, 82 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/11058/4
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11058/3/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11058/3/docs/administration.adoc@686
PS3, Line 686: . Start all of the tablet servers.
I pointed at this in previous revisions, but I don't see it addressed as I would expect. So, I'm just re-iterating over this point again.
Does it make sense to verify that masters are working property _before_ starting all the tablet servers?
The rationale is that if there was an error while migrating masters, it might be better to detect that problem earlier than later after starting all tablet servers.
What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Aug 2018 00:43:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Jul 2018 23:28:11 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11058/3/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11058/3/docs/administration.adoc@686
PS3, Line 686: . Start all of the tablet servers.
> It makes sense. So adding the check at the /masters page should be before s
I think ksck is not the only way to verify that masters are working properly. In addition to checking /masters page at the Web UI, we can recommend running
kudu master list <master_addresses>
I think performing those two verification steps is enough after starting just masters. If no errors are reported, next step is starting all tablet servers and running 'kudu cluster ksck <master_addresses>'
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Aug 2018 04:01:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@676
PS1, Line 676: new-master-name-1
> I agree it should be FQDN here (for best practices's sake), and maybe it's
added .example.com to all hostnames to indicate this
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@679
PS1, Line 679: master_addresses
> Right, that was my point -- if IP addresses changed, I though it would be n
Done
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@681
PS1, Line 681: tserver_master_addrs
> same as above
Done
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 30 Jul 2018 15:43:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 2:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@663
PS1, Line 663: masters
> new masters ?
well, they're the same masters as previously, just the hostnames change, so I think it's fine
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@664
PS1, Line 664: resolve them.
> nit: missing period
Done
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@670
PS1, Line 670: 00000000000
> For this scenario, it's supposed to be 00000000000000000000000000000000 alw
Done
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@676
PS1, Line 676: new-master-name-1
> Does it make sense to point that those names might be either FQDN or IP add
it should always be FQDN, with IPs Kerberos wouldn't work properly by default (unless the hosts don't have hostnames at all, which is unlikely)
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@679
PS1, Line 679: master_addresses
> Does it make sense to mention that the '--rpc_bind_addresses' and '--webser
hostname change shouldn't affect that, unless they switch IP address as well
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@681
PS1, Line 681: tserver_master_addrs
> Does it make sense to mention that the '--rpc_bind_addresses' and '--webser
same as above
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@684
PS1, Line 684: . Start up the masters.
> Does it make sense to run some verification after this step? Like 'kudu ma
verification is suggested in a later step
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@686
PS1, Line 686: Start all of the tablet servers.
> Does it make sense to run a verification step after that? Say, 'sudo -u ku
verification is suggested in a later step
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@696
PS1, Line 696:
> Maybe, make those match with the names used for Raft configuration change i
Done
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@709
PS1, Line 709: ----
: +
: .. In `impala-shell`, run:
: +
: [source,bash]
: ----
: INVALIDATE METADATA;
: ----
: +
: .. Verify updating the metadata worked
> I think it make sense to do so prior to Impala and HMS-related changes.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 27 Jul 2018 09:09:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11058/3/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11058/3/docs/administration.adoc@686
PS3, Line 686: . Start all of the tablet servers.
> I pointed at this in previous revisions, but I don't see it addressed as I
It makes sense. So adding the check at the /masters page should be before starting the tablet servers and the ksck after? Running ksck with no tablet servers could be a bit scary.
To be honest, maybe that one should be removed or an additional note should be added to explain that they might see unavailable tablets as it takes some time for all tablets to start.
What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Aug 2018 08:22:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11058
to look at the new patch set (#2).
Change subject: [docs] Add changing master hostnames workflow
......................................................................
[docs] Add changing master hostnames workflow
Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
---
M docs/administration.adoc
1 file changed, 73 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/11058/2
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
[docs] Add changing master hostnames workflow
Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Reviewed-on: http://gerrit.cloudera.org:8080/11058
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/administration.adoc
1 file changed, 82 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@663
PS1, Line 663: masters
new masters ?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@664
PS1, Line 664: resolve them
nit: missing period
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@670
PS1, Line 670: <tablet_id>
For this scenario, it's supposed to be 00000000000000000000000000000000 always, isn't it?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@676
PS1, Line 676: new-master-name-1
Does it make sense to point that those names might be either FQDN or IP addresses? And the recommended way is to use FQDNs for those, right?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@679
PS1, Line 679: master_addresses
Does it make sense to mention that the '--rpc_bind_addresses' and '--webserver_interface' should be updated at the new hosts if any custom values were set?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@681
PS1, Line 681: tserver_master_addrs
Does it make sense to mention that the '--rpc_bind_addresses' and '--webserver_interface' should be updated at the new hosts if any custom values were set?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@684
PS1, Line 684: . Start up the masters.
Does it make sense to run some verification after this step? Like 'kudu master list' or 'kudu master status'?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@686
PS1, Line 686: Start all of the tablet servers.
Does it make sense to run a verification step after that? Say, 'sudo -u kudu kudu cluster ksck <master_addresses>'?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@696
PS1, Line 696: new-master-name-1.example.com,new-master-name-2.example.com,new-master-name-3.example.com
Maybe, make those match with the names used for Raft configuration change in the 'kudu local_replica cmeta rewrite_raft_config' command above?
http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@709
PS1, Line 709: ==== Verify the migration was successful
:
: To verify that all masters are working properly, perform the following sanity checks:
:
: * Using a browser, visit each master's web UI. Look at the /masters page. All of the masters should
: be listed there with one master in the LEADER role and the others in the FOLLOWER role. The
: contents of /masters on each master should be the same.
:
: * Run a Kudu system check (ksck) on the cluster using the `kudu` command line
: tool. See <<ksck>> for more details.
I think it make sense to do so prior to Impala and HMS-related changes.
BTW, I think it would make sense to add a verification step for the Impala+Kudu case as well.
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Jul 2018 20:58:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11058
to look at the new patch set (#3).
Change subject: [docs] Add changing master hostnames workflow
......................................................................
[docs] Add changing master hostnames workflow
Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
---
M docs/administration.adoc
1 file changed, 74 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/11058/3
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11058/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11058/2/docs/administration.adoc@718
PS2, Line 718: SELECT
nit: surround in backticks
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 19:03:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add changing master hostnames workflow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow
......................................................................
Patch Set 4: Code-Review+2
Thank you for addressing my concerns!
--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Aug 2018 16:48:25 +0000
Gerrit-HasComments: No