You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jon Hermes (JIRA)" <ji...@apache.org> on 2011/01/28 00:23:47 UTC

[jira] Created: (CASSANDRA-2071) RP.describeOwnership() does some bad math

RP.describeOwnership() does some bad math
-----------------------------------------

                 Key: CASSANDRA-2071
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2071
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.7.0
            Reporter: Jon Hermes
            Assignee: Jon Hermes
            Priority: Minor


If the input isn't sorted correctly for some reason, then describeOwnership() fails to calculate the ownership %ages correctly.

Repro is 2 nodes with these tokens, you get these fractions:
49000620740128447720217646403197156812 : 0.7615167
770141183460469231731687303715884105727 : 4.2384834

423% ownership is obviously broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-2071) RP.describeOwnership() does some bad math

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2071:
--------------------------------------

    Remaining Estimate: 2h
     Original Estimate: 2h

> RP.describeOwnership() does some bad math
> -----------------------------------------
>
>                 Key: CASSANDRA-2071
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2071
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jon Hermes
>            Assignee: Jon Hermes
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 2071.txt
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If the input isn't sorted correctly for some reason, then describeOwnership() fails to calculate the ownership %ages correctly.
> Repro is 2 nodes with these tokens, you get these fractions:
> 49000620740128447720217646403197156812 : 0.7615167
> 770141183460469231731687303715884105727 : 4.2384834
> 423% ownership is obviously broken.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-2071) RP.describeOwnership() does some bad math

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987836#action_12987836 ] 

Hudson commented on CASSANDRA-2071:
-----------------------------------

Integrated in Cassandra-0.7 #223 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/223/])
    Fix RP.describeOwnership()
Patch by Jon Hermes, reviewed by brandonwilliams for CASSANDRA-2071


> RP.describeOwnership() does some bad math
> -----------------------------------------
>
>                 Key: CASSANDRA-2071
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2071
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jon Hermes
>            Assignee: Jon Hermes
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 2071.txt
>
>
> If the input isn't sorted correctly for some reason, then describeOwnership() fails to calculate the ownership %ages correctly.
> Repro is 2 nodes with these tokens, you get these fractions:
> 49000620740128447720217646403197156812 : 0.7615167
> 770141183460469231731687303715884105727 : 4.2384834
> 423% ownership is obviously broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-2071) RP.describeOwnership() does some bad math

Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Hermes updated CASSANDRA-2071:
----------------------------------

    Attachment: 2071.txt

Whoops, wrong file.

> RP.describeOwnership() does some bad math
> -----------------------------------------
>
>                 Key: CASSANDRA-2071
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2071
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jon Hermes
>            Assignee: Jon Hermes
>            Priority: Minor
>         Attachments: 2071.txt
>
>
> If the input isn't sorted correctly for some reason, then describeOwnership() fails to calculate the ownership %ages correctly.
> Repro is 2 nodes with these tokens, you get these fractions:
> 49000620740128447720217646403197156812 : 0.7615167
> 770141183460469231731687303715884105727 : 4.2384834
> 423% ownership is obviously broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-2071) RP.describeOwnership() does some bad math

Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Hermes updated CASSANDRA-2071:
----------------------------------

    Attachment: 2071.txt

Fixes the math by using a closed form in all cases.

Now returns:
49000620740128447720217646403197156812 : 0.7615167
770141183460469231731687303715884105727 : 0.2384833


> RP.describeOwnership() does some bad math
> -----------------------------------------
>
>                 Key: CASSANDRA-2071
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2071
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jon Hermes
>            Assignee: Jon Hermes
>            Priority: Minor
>         Attachments: 2071.txt
>
>
> If the input isn't sorted correctly for some reason, then describeOwnership() fails to calculate the ownership %ages correctly.
> Repro is 2 nodes with these tokens, you get these fractions:
> 49000620740128447720217646403197156812 : 0.7615167
> 770141183460469231731687303715884105727 : 4.2384834
> 423% ownership is obviously broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-2071) RP.describeOwnership() does some bad math

Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Hermes updated CASSANDRA-2071:
----------------------------------

    Attachment:     (was: 2071.txt)

> RP.describeOwnership() does some bad math
> -----------------------------------------
>
>                 Key: CASSANDRA-2071
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2071
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jon Hermes
>            Assignee: Jon Hermes
>            Priority: Minor
>         Attachments: 2071.txt
>
>
> If the input isn't sorted correctly for some reason, then describeOwnership() fails to calculate the ownership %ages correctly.
> Repro is 2 nodes with these tokens, you get these fractions:
> 49000620740128447720217646403197156812 : 0.7615167
> 770141183460469231731687303715884105727 : 4.2384834
> 423% ownership is obviously broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.