You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/07 12:36:02 UTC
[GitHub] [arrow] lukester1975 opened a new issue, #14869: [C++] arrow.pc should have -DARROW_STATIC for Windows static builds
lukester1975 opened a new issue, #14869:
URL: https://github.com/apache/arrow/issues/14869
### Describe the enhancement requested
Without, the generated pc file is insufficient (at least without "manually" defining ARROW_STATIC, which is unpleasant).
Quick hack fix: https://github.com/lukester1975/arrow/commit/2a8efd9c0bf69fe1b466e157bd69e83a757c926e
* Cflags.private is quite new (https://gitlab.freedesktop.org/pkg-config/pkg-config/-/merge_requests/13), so this approach might be unpalatable.
* pkgconfiglite is too old to include that (no commits since 2016??). It does quietly ignore the field, though.
* vcpkg does its own merging of Cflags.private into Cflags, so not an issue if pkg-config doesn't understand Cflags.private there (my case).
* Obviously this is applying to all platforms, not just Windows, but should do no harm...?
Seems like there should be some sort of fix here rather than asking vcpkg to patch it!
Regards
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lukester1975 commented on issue #14869: [C++] arrow.pc should have -DARROW_STATIC for Windows static builds
Posted by GitBox <gi...@apache.org>.
lukester1975 commented on issue #14869:
URL: https://github.com/apache/arrow/issues/14869#issuecomment-1342412276
Sure, can do.
Are the other `pc.in`s required, though? They all `Requires: arrow` (directly or indirectly) so should inherit the flag from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #14869: [C++] arrow.pc should have -DARROW_STATIC for Windows static builds
Posted by GitBox <gi...@apache.org>.
kou commented on issue #14869:
URL: https://github.com/apache/arrow/issues/14869#issuecomment-1343413790
We have separated `_STATIC` macro for each modules. For example, we have `PARQUET_STATIC` for Parquet and `ARROW_DS_STATIC` for Arrow Dataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed issue #14869: [C++] arrow.pc should have -DARROW_STATIC for Windows static builds
Posted by GitBox <gi...@apache.org>.
kou closed issue #14869: [C++] arrow.pc should have -DARROW_STATIC for Windows static builds
URL: https://github.com/apache/arrow/issues/14869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #14869: [C++] arrow.pc should have -DARROW_STATIC for Windows static builds
Posted by GitBox <gi...@apache.org>.
kou commented on issue #14869:
URL: https://github.com/apache/arrow/issues/14869#issuecomment-1341770774
Could you open a pull request with your approach?
pkgconf that is a drop-in replacement of pkg-config supports `Cflags.private`: http://pkgconf.org/features.html
So we can use `Cflags.private` for it.
We also need similar change to all other `*.pc.in` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org