You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aditi Dixit <ad...@gmail.com> on 2015/06/04 13:21:41 UTC
Review Request 35064: Added help for slave
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35064/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-2277
https://issues.apache.org/jira/browse/MESOS-2277
Repository: mesos
Description
-------
Added slave help
Diffs
-----
src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54
src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
Diff: https://reviews.apache.org/r/35064/diff/
Testing
-------
make check
Thanks,
Aditi Dixit
Re: Review Request 35064: Added help for slave
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35064/#review86729
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 4, 2015, 11:21 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35064/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 11:21 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-2277
> https://issues.apache.org/jira/browse/MESOS-2277
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added slave help
>
>
> Diffs
> -----
>
> src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54
> src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
> src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
>
> Diff: https://reviews.apache.org/r/35064/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 35064: Added help for slave
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35064/#review86589
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35064]
All tests passed.
- Mesos ReviewBot
On June 4, 2015, 11:21 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35064/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 11:21 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-2277
> https://issues.apache.org/jira/browse/MESOS-2277
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added slave help
>
>
> Diffs
> -----
>
> src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54
> src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
> src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
>
> Diff: https://reviews.apache.org/r/35064/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 35064: Added help for slave
Posted by Vinod Kone <vi...@gmail.com>.
> On June 4, 2015, 6:30 p.m., Niklas Nielsen wrote:
> > Did you mean to create a new review request? Remember to add the line with 'Review: https://reviews.apache.org/r/XYZ/' to the commit message, to update the review with post reviews :)
Yes. Please use post-reviews instead of rbt directly.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35064/#review86685
-----------------------------------------------------------
On June 4, 2015, 11:21 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35064/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 11:21 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-2277
> https://issues.apache.org/jira/browse/MESOS-2277
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added slave help
>
>
> Diffs
> -----
>
> src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54
> src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
> src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
>
> Diff: https://reviews.apache.org/r/35064/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 35064: Added help for slave
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35064/#review86685
-----------------------------------------------------------
Did you mean to create a new review request? Remember to add the line with 'Review: https://reviews.apache.org/r/XYZ/' to the commit message, to update the review with post reviews :)
- Niklas Nielsen
On June 4, 2015, 4:21 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35064/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 4:21 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-2277
> https://issues.apache.org/jira/browse/MESOS-2277
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added slave help
>
>
> Diffs
> -----
>
> src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54
> src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
> src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
>
> Diff: https://reviews.apache.org/r/35064/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>