[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1405: Makefile: replace DEFINE to DEFINE_PREFIX

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #1405:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1405#discussion_r1018436786


##########
crypto/mbedtls/Makefile:
##########
@@ -36,7 +36,7 @@ MBEDTLS_UNPACKLIBDIR = $(MBEDTLS_UNPACKNAME)$(DELIM)library
 MBEDTLS_UNPACKPROGDIR = $(MBEDTLS_UNPACKNAME)$(DELIM)programs
 
 # This lets Mbed TLS better use some of the POSIX features we have
-CFLAGS += ${shell $(DEFINE) "$(CC)" __unix__}
+CFLAGS += ${DEFINE_PREFIX}__unix__}

Review Comment:
   ```suggestion
   CFLAGS += ${DEFINE_PREFIX}__unix__
   ```



##########
crypto/mbedtls/Make.defs:
##########
@@ -26,7 +26,7 @@ CONFIGURED_APPS += $(APPDIR)/crypto/mbedtls
 CFLAGS += ${shell $(INCDIR) "$(CC)" $(APPDIR)/crypto/mbedtls/mbedtls/include}
 CXXFLAGS += ${shell $(INCDIR) "$(CC)" $(APPDIR)/crypto/mbedtls/mbedtls/include}
 
-CFLAGS += ${shell $(DEFINE) "$(CC)" MBEDTLS_CONFIG_FILE='"<crypto/mbedtls_config.h>"'}
-CXXFLAGS += ${shell $(DEFINE) "$(CC)" MBEDTLS_CONFIG_FILE='"<crypto/mbedtls_config.h>"'}
+CFLAGS += ${DEFINE_PREFIX}MBEDTLS_CONFIG_FILE='"<crypto/mbedtls_config.h>"'}
+CXXFLAGS += ${DEFINE_PREFIX}MBEDTLS_CONFIG_FILE='"<crypto/mbedtls_config.h>"'}

Review Comment:
   ```suggestion
   CFLAGS += ${DEFINE_PREFIX}MBEDTLS_CONFIG_FILE='"<crypto/mbedtls_config.h>"'
   CXXFLAGS += ${DEFINE_PREFIX}MBEDTLS_CONFIG_FILE='"<crypto/mbedtls_config.h>"'
   ```



##########
system/argtable3/Makefile:
##########
@@ -28,7 +28,7 @@ ARGTABLE3_SRCDIR   = $(ARGTABLE3_UNPACK)$(DELIM)src
 DEPPATH += --dep-path $(ARGTABLE3_SRCDIR)
 VPATH   += :$(ARGTABLE3_SRCDIR)
 
-CFLAGS += ${shell $(DEFINE) "$(CC)" ARG_REPLACE_GETOPT=0}
+CFLAGS += ${DEFINE_PREFIX}ARG_REPLACE_GETOPT=0}

Review Comment:
   ```suggestion
   CFLAGS += ${DEFINE_PREFIX}ARG_REPLACE_GETOPT=0
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org