You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/06/27 07:40:38 UTC

[GitHub] zeppelin pull request #1092: [ZEPPELIN-1064] Flaky Test - ParagraphActionsIT...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/1092

    [ZEPPELIN-1064] Flaky Test - ParagraphActionsIT.testTitleButton

    ### What is this PR for?
    This is fix for test failing in CI
    
    ```
    testTitleButton(org.apache.zeppelin.integration.ParagraphActionsIT)  Time elapsed: 11.11 sec  <<< FAILURE!
    java.lang.AssertionError: After Show Title : The title field contains
    Expected: "Untitled"
         but: was ""
    	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    	at org.junit.Assert.assertThat(Assert.java:865)
    	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
    	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
    	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
    	at org.apache.zeppelin.integration.ParagraphActionsIT.testTitleButton(ParagraphActionsIT.java:350)
    ```
    
    ### What type of PR is it?
    [Bug Fix | Test]
    
    ### Todos
    * [x] - add delay before checking the values
    
    ### What is the Jira issue?
    * [ZEPPELIN-1064](https://issues.apache.org/jira/browse/ZEPPELIN-1064)
    
    ### How should this be tested?
    CI should be green
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1064

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1092.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1092
    
----
commit 830f34b94f01b09bc5fc256c05830ecef1fc064c
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2016-06-27T07:38:38Z

    add delay before checking the values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1092: [ZEPPELIN-1064] Flaky Test - ParagraphActionsIT.testTi...

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1092
  
    CI passes now, and changes looks great to me.
    
    Let's merge if there is no further discussion



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1092: [ZEPPELIN-1064] Flaky Test - ParagraphActionsIT...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1092


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1092: [ZEPPELIN-1064] Flaky Test - ParagraphActionsIT.testTi...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1092
  
    Thanks @prabhjyotsingh taking care of it. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---