[GitHub] [accumulo] dlmarion commented on a diff in pull request #2672: Add new blip count to GC

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #2672:
URL: https://github.com/apache/accumulo/pull/2672#discussion_r864749864


##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##########
@@ -206,6 +212,7 @@ private void confirmDeletes(GarbageCollectionEnvironment gce,
 
     confirmDeletesFromReplication(gce.getReplicationNeededIterator(),
         candidateMap.entrySet().iterator());
+    return blipCount;
   }
 
   protected void confirmDeletesFromReplication(

Review Comment:
   This could be marked as deprecated so we know to remove it later.



##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##########
@@ -269,17 +276,19 @@ private void cleanUpDeletedTableDirs(GarbageCollectionEnvironment gce,
     }
   }
 
-  private void confirmDeletesTrace(GarbageCollectionEnvironment gce,
+  private long confirmDeletesTrace(GarbageCollectionEnvironment gce,

Review Comment:
   I'm not sure we need a separate method to enable tracing. I think we should add the tracing to the `confirmDeletes` method and remove this.



##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##########
@@ -127,9 +127,13 @@ private SortedMap<String,String> makeRelative(Collection<String> candidates) {
     return ret;
   }
 
-  private void confirmDeletes(GarbageCollectionEnvironment gce,
+  /**
+   * Return the number of BLIP flags seen.
+   */
+  private long confirmDeletes(GarbageCollectionEnvironment gce,

Review Comment:
   I feel like this method should be renamed to `removeBlipCandidates`  or something a little more descriptive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org