You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2025/06/06 15:18:46 UTC

[PR] Fix structure edges [airflow]

pierrejeambrun opened a new pull request, #51484:
URL: https://github.com/apache/airflow/pull/51484

   While working on https://github.com/apache/airflow/pull/51481 I realized I had some really weird cases of duplicate and removed edges where really it shouldn't.
   
   After investigation it appears that https://github.com/apache/airflow/pull/47381 broke a few things, cf comments bellow.
   
   I don't know how this went unnoticed and didn't break completely the structure from a user / unit test perspective but I think we should release that as soon as possible.
   
   cc: @kaxil, just in case there's another rc for 3.0.2, I think this one should be included if we get the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix structure edges [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #51484:
URL: https://github.com/apache/airflow/pull/51484#discussion_r2132393064


##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/structure.py:
##########
@@ -138,9 +138,9 @@ def structure_data(
                 asset_expression, entry_node_ref["id"]
             )
             data["nodes"] += upstream_asset_nodes
-            data["edges"] = upstream_asset_edges
+            data["edges"] += upstream_asset_edges
 
-        data["edges"] += start_edges + edges + end_edges

Review Comment:
   This was duplicating `edges`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix structure edges [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #51484:
URL: https://github.com/apache/airflow/pull/51484#discussion_r2132392262


##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/structure.py:
##########
@@ -138,9 +138,9 @@ def structure_data(
                 asset_expression, entry_node_ref["id"]
             )
             data["nodes"] += upstream_asset_nodes
-            data["edges"] = upstream_asset_edges
+            data["edges"] += upstream_asset_edges

Review Comment:
   This was overriding the original edges coming from `dag_edges`.



##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/structure.py:
##########
@@ -138,9 +138,9 @@ def structure_data(
                 asset_expression, entry_node_ref["id"]
             )
             data["nodes"] += upstream_asset_nodes
-            data["edges"] = upstream_asset_edges
+            data["edges"] += upstream_asset_edges
 
-        data["edges"] += start_edges + edges + end_edges

Review Comment:
   This was duplicated `edges`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix structure edges [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #51484:
URL: https://github.com/apache/airflow/pull/51484#discussion_r2132393064


##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/structure.py:
##########
@@ -138,9 +138,9 @@ def structure_data(
                 asset_expression, entry_node_ref["id"]
             )
             data["nodes"] += upstream_asset_nodes
-            data["edges"] = upstream_asset_edges
+            data["edges"] += upstream_asset_edges
 
-        data["edges"] += start_edges + edges + end_edges

Review Comment:
   This was duplicating `edges`. (data["edges"] is already assigned to edges)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix structure edges [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #51484:
URL: https://github.com/apache/airflow/pull/51484#discussion_r2132393064


##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/structure.py:
##########
@@ -138,9 +138,9 @@ def structure_data(
                 asset_expression, entry_node_ref["id"]
             )
             data["nodes"] += upstream_asset_nodes
-            data["edges"] = upstream_asset_edges
+            data["edges"] += upstream_asset_edges
 
-        data["edges"] += start_edges + edges + end_edges

Review Comment:
   This was duplicating `edges`. (`data["edges"]` is already assigned to `edges`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix structure edges [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51484:
URL: https://github.com/apache/airflow/pull/51484#issuecomment-2950044181

   ### Backport successfully created: v3-0-test
   
   <table>
                   <tr>
                       <th>Status</th>
                       <th>Branch</th>
                       <th>Result</th>
                   </tr>
                   <tr>
                       <td>✅</td>
                       <td>v3-0-test</td>
                       <td><a href="https://github.com/apache/airflow/pull/51489"><img src="https://img.shields.io/badge/PR-51489-blue" alt="PR Link"></a></td>
                   </tr>
               </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix structure edges [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #51484:
URL: https://github.com/apache/airflow/pull/51484


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org