You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/29 03:58:25 UTC
[GitHub] [incubator-shardingsphere] yuzel opened a new pull request #4525:
#4482 Correct the `DataTypeName` for PostgreSQL
yuzel opened a new pull request #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525
Fixes #4482.
Changes proposed in this pull request:
- add PostgreSQL dataType
Note:
- doublePrecision is support `double precision` . [DATATYPE-FLOAT](http://www.postgres.cn/docs/11/datatype-numeric.html#DATATYPE-FLOAT)
- identifier is support `complex type` [ROWTYPES-DECLARING](http://www.postgres.cn/docs/11/rowtypes.html#ROWTYPES-DECLARING)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4525:
#4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#issuecomment-592878489
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@95779d7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `10.32%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4525 +/- ##
=========================================
Coverage ? 55.47%
Complexity ? 331
=========================================
Files ? 953
Lines ? 17942
Branches ? 3396
=========================================
Hits ? 9953
Misses ? 7348
Partials ? 641
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/ddl/column/alter/AddColumnDefinitionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kZGwvY29sdW1uL2FsdGVyL0FkZENvbHVtbkRlZmluaXRpb25TZWdtZW50LmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...dl/column/alter/ModifyColumnDefinitionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kZGwvY29sdW1uL2FsdGVyL01vZGlmeUNvbHVtbkRlZmluaXRpb25TZWdtZW50LmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...nt/ddl/constraint/ConstraintDefinitionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kZGwvY29uc3RyYWludC9Db25zdHJhaW50RGVmaW5pdGlvblNlZ21lbnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...l/segment/dml/item/ShorthandProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9TaG9ydGhhbmRQcm9qZWN0aW9uU2VnbWVudC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...e/sql/parser/sql/segment/generic/TableSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9nZW5lcmljL1RhYmxlU2VnbWVudC5qYXZh) | `33.33% <ø> (ø)` | `0 <0> (?)` | |
| [...l/parser/sql/segment/dml/column/ColumnSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvY29sdW1uL0NvbHVtblNlZ21lbnQuamF2YQ==) | `50% <ø> (ø)` | `0 <0> (?)` | |
| [...er/sql/statement/generic/AbstractSQLStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2dlbmVyaWMvQWJzdHJhY3RTUUxTdGF0ZW1lbnQuamF2YQ==) | `100% <ø> (ø)` | `1 <0> (?)` | |
| [.../sql/parser/sql/statement/dcl/RevokeStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RjbC9SZXZva2VTdGF0ZW1lbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ingsphere/sql/parser/visitor/SQLServerVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL1NRTFNlcnZlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| ... and [33 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=footer). Last update [95779d7...88f3a0c](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4525:
#4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#issuecomment-592879744
## Pull Request Test Coverage Report for [Build 9872](https://coveralls.io/builds/29043384)
* **0** of **6** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.03%**) to **59.113%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/29043384/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L464) | 0 | 6 | 0.0%
<!-- | **Total:** | **0** | **6** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/29043384/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L472) | 1 | 0% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29043384/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **4** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/29043384/badge)](https://coveralls.io/builds/29043384) |
| :-- | --: |
| Change from base [Build 952](https://coveralls.io/builds/29042653): | -0.03% |
| Covered Lines: | 10606 |
| Relevant Lines: | 17942 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue
#4525: #4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#issuecomment-592878489
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@95779d7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `3.68%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4525 +/- ##
=========================================
Coverage ? 55.16%
Complexity ? 331
=========================================
Files ? 954
Lines ? 17963
Branches ? 3398
=========================================
Hits ? 9909
Misses ? 7421
Partials ? 633
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../sql/parser/sql/statement/dml/SelectStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnQuamF2YQ==) | `4.34% <ø> (ø)` | `0 <0> (?)` | |
| [...t/ddl/column/alter/AddColumnDefinitionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kZGwvY29sdW1uL2FsdGVyL0FkZENvbHVtbkRlZmluaXRpb25TZWdtZW50LmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...dl/column/alter/ModifyColumnDefinitionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kZGwvY29sdW1uL2FsdGVyL01vZGlmeUNvbHVtbkRlZmluaXRpb25TZWdtZW50LmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...nt/ddl/constraint/ConstraintDefinitionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kZGwvY29uc3RyYWludC9Db25zdHJhaW50RGVmaW5pdGlvblNlZ21lbnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../sql/parser/sql/statement/dml/UpdateStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9VcGRhdGVTdGF0ZW1lbnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...l/segment/dml/item/ShorthandProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9TaG9ydGhhbmRQcm9qZWN0aW9uU2VnbWVudC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...e/sql/parser/sql/segment/generic/TableSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9nZW5lcmljL1RhYmxlU2VnbWVudC5qYXZh) | `33.33% <ø> (ø)` | `0 <0> (?)` | |
| [...l/parser/sql/segment/dml/column/ColumnSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvY29sdW1uL0NvbHVtblNlZ21lbnQuamF2YQ==) | `50% <ø> (ø)` | `0 <0> (?)` | |
| [.../sql/parser/sql/statement/dml/DeleteStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9EZWxldGVTdGF0ZW1lbnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...er/sql/statement/generic/AbstractSQLStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2dlbmVyaWMvQWJzdHJhY3RTUUxTdGF0ZW1lbnQuamF2YQ==) | `100% <ø> (ø)` | `1 <0> (?)` | |
| ... and [33 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=footer). Last update [95779d7...8cab634](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] yuzel commented on issue #4525: #4482
Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
yuzel commented on issue #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#issuecomment-593062334
> I wonder whether you want to continue to involve in the community to do anything interesting or go on with #4482?
Yes, I want to continue to participate and contribute to the community. # 4482 I will continue to finish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] yuzel commented on a change in pull
request #4525: #4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
yuzel commented on a change in pull request #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#discussion_r386021630
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -303,7 +303,14 @@ dataType
;
dataTypeName
- : identifier
+ : INT | SMALLINT | INTEGER | BIGINT | DECIMAL | NUMERIC | REAL | FLOAT | doublePrecision | SMALLSERIAL | SERIAL | BIGSERIAL
+ | MONEY | VARCHAR | CHARACTER | CHAR | TEXT | NAME | BYTEA | TIMESTAMP | DATE | TIME | INTERVAL | BOOLEAN | ENUM | POINT
+ | LINE | LSEG | BOX | PATH | POLYGON | CIRCLE | CIDR | INET | MACADDR | BIT | VARBIT | TSVECTOR | TSQUERY | UUID | XML
+ | JSON | INTRANGE | NUMRANGE | TSRANGE | TSTZRANGE | DATERANGE | ARRAY | identifier
+ ;
+
+doublePrecision
Review comment:
> Why does `doublePrecision` not exist in `PostgreSQLKeyword.g4 `?
DOUBLE and PRECISION exist in KeyWord.g4, so I added an expression to represent double precision. Now I find that it is better to add keywords directly, I will change to keyword and remove doublePrecision.
`DOUBLEPRECISION
: D O U B L E [ ]+ P R E C I S I O N
;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #4525: #4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#discussion_r386017412
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java
##########
@@ -460,6 +461,14 @@ public final ASTNode visitCaseExpression(final CaseExpressionContext ctx) {
@Override
public final ASTNode visitDataTypeName(final DataTypeNameContext ctx) {
+ DoublePrecisionContext doublePrecisionContext = ctx.doublePrecision();
+ if (null != doublePrecisionContext) {
Review comment:
Here is a better way,
```
if (null != doublePrecisionContext) {
return visit(ctx.doublePrecision());
}
@Override
public final ASTNode visitDoublePrecision(final DoublePrecisionContext ctx) {
return new KeywordValue(xxxx);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4525: #4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#issuecomment-592879744
## Pull Request Test Coverage Report for [Build 9886](https://coveralls.io/builds/29045602)
* **0** of **3** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **85** unchanged lines in **7** files lost coverage.
* Overall coverage decreased (**-0.4%**) to **58.749%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/29045602/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L463) | 0 | 3 | 0.0%
<!-- | **Total:** | **0** | **3** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/29045602/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L467) | 1 | 0% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29045602/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/table/TablesContext.java](https://coveralls.io/builds/29045602/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Ftable%2FTablesContext.java#L72) | 3 | 95.77% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/select/projection/engine/ProjectionsContextEngine.java](https://coveralls.io/builds/29045602/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Fselect%2Fprojection%2Fengine%2FProjectionsContextEngine.java#L184) | 6 | 78.89% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/DeleteStatement.java](https://coveralls.io/builds/29045602/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FDeleteStatement.java#L39) | 14 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/UpdateStatement.java](https://coveralls.io/builds/29045602/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FUpdateStatement.java#L40) | 14 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/29045602/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L74) | 44 | 4.35% |
<!-- | **Total:** | **85** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/29045602/badge)](https://coveralls.io/builds/29045602) |
| :-- | --: |
| Change from base [Build 952](https://coveralls.io/builds/29042653): | -0.4% |
| Covered Lines: | 10553 |
| Relevant Lines: | 17963 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #4525: #4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#discussion_r386018115
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -303,7 +303,14 @@ dataType
;
dataTypeName
- : identifier
+ : INT | SMALLINT | INTEGER | BIGINT | DECIMAL | NUMERIC | REAL | FLOAT | doublePrecision | SMALLSERIAL | SERIAL | BIGSERIAL
+ | MONEY | VARCHAR | CHARACTER | CHAR | TEXT | NAME | BYTEA | TIMESTAMP | DATE | TIME | INTERVAL | BOOLEAN | ENUM | POINT
+ | LINE | LSEG | BOX | PATH | POLYGON | CIRCLE | CIDR | INET | MACADDR | BIT | VARBIT | TSVECTOR | TSQUERY | UUID | XML
+ | JSON | INTRANGE | NUMRANGE | TSRANGE | TSTZRANGE | DATERANGE | ARRAY | identifier
+ ;
+
+doublePrecision
Review comment:
Why does `doublePrecision` not exist in `PostgreSQLKeyword.g4 `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4525:
#4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4525:
#4482 Correct the `DataTypeName` for PostgreSQL
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4525: #4482 Correct the `DataTypeName` for PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/4525#issuecomment-593066899
> Yes, I want to continue to participate and contribute to the community. # 4482 I will continue to finish.
@yuzel
Very welcome. But my suggestion is to follow your own pace since I do not want this issue to stress you too much. 😃
Grow up with the community and demonstrate your capabilities!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services