[jira] Commented: (MAPREDUCE-894) DBInputformat not working with SQLServer

["Aaron Kimball (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752749#action_12752749 ] 

Aaron Kimball commented on MAPREDUCE-894:
-----------------------------------------

+1 - patch looks good subject to comments below.

Some small notes about the patch:

* In the case where orderBy is null/empty, your {{"SELECT OVER (ORDER BY " +  allFieldNames + " ASC)"}} will put the ASC after the final field name in the list. (e.g {{ORDER BY foo, bar, baz ASC}}) Is this correct SQL? Or is an ASC required after each comma-delimited field in the list?
* A nitpick: You use mixed tabs and spaces. Can you convert your new tabs to 2 spaces each?

Finally, since this depends on SQL Server, it doesn't include any new tests. Can you please describe what tests you ran to demonstrate correctness?


> DBInputformat not working with SQLServer
> ----------------------------------------
>
>                 Key: MAPREDUCE-894
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-894
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>    Affects Versions: 0.21.0
>            Reporter: Budianto Lie
>         Attachments: MAPREDUCE-894.patch
>
>
> org.apache.hadoop.mapreduce.lib.db.DBInputFormat
> Microsoft SQLServer doesn't support LIMIT and OFFSET.
> Fix:
> Based on MAPREDUCE-716, I already implemented it.
> By creating a new class org.apache.hadoop.mapreduce.lib.db.MsSqlDBRecordReader 
> and modifying class org.apache.hadoop.mapreduce.lib.db.DBInputFormat 
> Note: this fix is working only with SQLServer 2005 or higher.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.