You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2016/01/05 15:42:54 UTC

[GitHub] couchdb-nmo pull request: [WIP] new isonline util function

GitHub user garrensmith opened a pull request:

    https://github.com/apache/couchdb-nmo/pull/18

    [WIP] new isonline util function

    THis is just a proof of concept for now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/garrensmith/couchdb-nmo online-checker

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-nmo/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
    
----
commit 64ef7573d51104ed44ec05243fb76ee97519b7c2
Author: Garren Smith <ga...@gmail.com>
Date:   2016-01-05T14:42:14Z

    new isonline util function

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-nmo pull request: new isonline util function

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-nmo/pull/18#issuecomment-170513017
  
    +1 after renaming the file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-nmo pull request: new isonline util function

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-nmo/pull/18#discussion_r49311164
  
    --- Diff: test/helpers.js ---
    @@ -1,3 +1,11 @@
    +import nock from 'nock';
    +
    +export function nodeIsOnline (url) {
    --- End diff --
    
    can we rename it to `fakeNodeIsOnline`, `mockNodeIsOnline` or something along the lines?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-nmo pull request: [WIP] new isonline util function

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-nmo/pull/18#issuecomment-169269646
  
    looks good, cool idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-nmo pull request: new isonline util function

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-nmo/pull/18#issuecomment-170828564
  
    Merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-nmo pull request: new isonline util function

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-nmo/pull/18#issuecomment-170513673
  
    oh!
    
    `isOnline` is not used for the query command


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-nmo pull request: new isonline util function

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith closed the pull request at:

    https://github.com/apache/couchdb-nmo/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---