You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/05/25 22:11:26 UTC

Review Request 67331: Documented the `linux/devices` isolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67331/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8792
    https://issues.apache.org/jira/browse/MESOS-8792


Repository: mesos


Description
-------

Documented the `linux/devices` isolator in the Mesos containerizer
documentation, upgrade guide and CHANGELOG.


Diffs
-----

  CHANGELOG b78915daeddc5126c5db0ada2de1bcd79caf2d6b 
  docs/isolators/linux-devices.md PRE-CREATION 
  docs/mesos-containerizer.md 42a09771000f6fdebc660f7d771e4cc17fd40ded 
  docs/upgrades.md fb6b865af5caa4ec7181842a257a8cf0aefd18f3 


Diff: https://reviews.apache.org/r/67331/diff/1/


Testing
-------

Manually build and viewed the website.


Thanks,

James Peach

Re: Review Request 67331: Documented the `linux/devices` isolator.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67331/#review204007
-----------------------------------------------------------



PASS: Mesos patch 67331 was successfully built and tested.

Reviews applied: `['67360', '67331']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67331

- Mesos Reviewbot Windows


On May 29, 2018, 5:45 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67331/
> -----------------------------------------------------------
> 
> (Updated May 29, 2018, 5:45 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
>     https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented the `linux/devices` isolator in the Mesos containerizer
> documentation, upgrade guide and CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG b78915daeddc5126c5db0ada2de1bcd79caf2d6b 
>   docs/isolators/linux-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 42a09771000f6fdebc660f7d771e4cc17fd40ded 
>   docs/upgrades.md fb6b865af5caa4ec7181842a257a8cf0aefd18f3 
> 
> 
> Diff: https://reviews.apache.org/r/67331/diff/2/
> 
> 
> Testing
> -------
> 
> Manually build and viewed the website.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67331: Documented the `linux/devices` isolator.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67331/
-----------------------------------------------------------

(Updated May 29, 2018, 5:45 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8792
    https://issues.apache.org/jira/browse/MESOS-8792


Repository: mesos


Description
-------

Documented the `linux/devices` isolator in the Mesos containerizer
documentation, upgrade guide and CHANGELOG.


Diffs (updated)
-----

  CHANGELOG b78915daeddc5126c5db0ada2de1bcd79caf2d6b 
  docs/isolators/linux-devices.md PRE-CREATION 
  docs/mesos-containerizer.md 42a09771000f6fdebc660f7d771e4cc17fd40ded 
  docs/upgrades.md fb6b865af5caa4ec7181842a257a8cf0aefd18f3 


Diff: https://reviews.apache.org/r/67331/diff/2/

Changes: https://reviews.apache.org/r/67331/diff/1-2/


Testing
-------

Manually build and viewed the website.


Thanks,

James Peach

Re: Review Request 67331: Documented the `linux/devices` isolator.

Posted by James Peach <jp...@apache.org>.

> On May 25, 2018, 11:31 p.m., Jie Yu wrote:
> > docs/isolators/linux-devices.md
> > Lines 14 (patched)
> > <https://reviews.apache.org/r/67331/diff/1/?file=2030676#file2030676line14>
> >
> >     Can you add some example of `--allowed_devices`, or provide a link to the example?

I added a link.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67331/#review203922
-----------------------------------------------------------


On May 25, 2018, 10:11 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67331/
> -----------------------------------------------------------
> 
> (Updated May 25, 2018, 10:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
>     https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented the `linux/devices` isolator in the Mesos containerizer
> documentation, upgrade guide and CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG b78915daeddc5126c5db0ada2de1bcd79caf2d6b 
>   docs/isolators/linux-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 42a09771000f6fdebc660f7d771e4cc17fd40ded 
>   docs/upgrades.md fb6b865af5caa4ec7181842a257a8cf0aefd18f3 
> 
> 
> Diff: https://reviews.apache.org/r/67331/diff/1/
> 
> 
> Testing
> -------
> 
> Manually build and viewed the website.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67331: Documented the `linux/devices` isolator.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67331/#review203922
-----------------------------------------------------------


Fix it, then Ship it!





docs/isolators/linux-devices.md
Lines 14 (patched)
<https://reviews.apache.org/r/67331/#comment286302>

    Can you add some example of `--allowed_devices`, or provide a link to the example?


- Jie Yu


On May 25, 2018, 10:11 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67331/
> -----------------------------------------------------------
> 
> (Updated May 25, 2018, 10:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
>     https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented the `linux/devices` isolator in the Mesos containerizer
> documentation, upgrade guide and CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG b78915daeddc5126c5db0ada2de1bcd79caf2d6b 
>   docs/isolators/linux-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 42a09771000f6fdebc660f7d771e4cc17fd40ded 
>   docs/upgrades.md fb6b865af5caa4ec7181842a257a8cf0aefd18f3 
> 
> 
> Diff: https://reviews.apache.org/r/67331/diff/1/
> 
> 
> Testing
> -------
> 
> Manually build and viewed the website.
> 
> 
> Thanks,
> 
> James Peach
> 
>