You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/13 04:04:38 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #34651: [SPARK-37373] Collecting LocalSparkContext worker logs in case of test failure

gengliangwang commented on a change in pull request #34651:
URL: https://github.com/apache/spark/pull/34651#discussion_r767399869



##########
File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala
##########
@@ -45,6 +47,7 @@ class LocalSparkCluster(
   private val workerRpcEnvs = ArrayBuffer[RpcEnv]()
   // exposed for testing
   var masterWebUIPort = -1
+  private val workerDirs = ArrayBuffer[String]()

Review comment:
       nit: add comments saying that this is test only




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org