You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2016/09/28 17:14:42 UTC
[trafficserver] branch master updated (160e7bf -> cab2ac3)
This is an automated email from the ASF dual-hosted git repository.
sorber pushed a change to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git.
from 160e7bf TS-4558: ASAN buffer overflow in traffic_manager -h
new 622677b TS-4699: Fix clang-analyzer
new ec4a19a TS-4699: Fix CID 1363288
new cab2ac3 TS-4699: Fix CID 1363290
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.
Summary of changes:
lib/atscppapi/examples/websocket/WSBuffer.cc | 6 ++++--
lib/atscppapi/examples/websocket/WebSocket.cc | 7 ++++++-
2 files changed, 10 insertions(+), 3 deletions(-)
--
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].
[trafficserver] 03/03: TS-4699: Fix CID 1363290
Posted by so...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
sorber pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git
commit cab2ac388e28d1102528eaa78c0d4e8e4cd1b91b
Author: Phil Sorber <so...@apache.org>
AuthorDate: Wed Sep 28 08:21:13 2016 -0600
TS-4699: Fix CID 1363290
---
lib/atscppapi/examples/websocket/WSBuffer.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/atscppapi/examples/websocket/WSBuffer.cc b/lib/atscppapi/examples/websocket/WSBuffer.cc
index 5cefa34..ee406a6 100644
--- a/lib/atscppapi/examples/websocket/WSBuffer.cc
+++ b/lib/atscppapi/examples/websocket/WSBuffer.cc
@@ -49,7 +49,7 @@
static const std::string magic = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
-WSBuffer::WSBuffer()
+WSBuffer::WSBuffer() : frame_(0)
{
}
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.
[trafficserver] 01/03: TS-4699: Fix clang-analyzer
Posted by so...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
sorber pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git
commit 622677b219268cdd4e86e7d21f7e24ade52700aa
Author: Phil Sorber <so...@apache.org>
AuthorDate: Tue Sep 27 23:21:00 2016 -0600
TS-4699: Fix clang-analyzer
---
lib/atscppapi/examples/websocket/WebSocket.cc | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/atscppapi/examples/websocket/WebSocket.cc b/lib/atscppapi/examples/websocket/WebSocket.cc
index c41352f..ee2ea54 100644
--- a/lib/atscppapi/examples/websocket/WebSocket.cc
+++ b/lib/atscppapi/examples/websocket/WebSocket.cc
@@ -28,13 +28,18 @@
// DISCLAIMER: this is intended for demonstration purposes only and
// does not pretend to implement a complete (or useful) server.
+namespace
+{
+GlobalPlugin *plugin;
+}
+
using namespace atscppapi;
void
TSPluginInit(int argc, const char *argv[])
{
RegisterGlobalPlugin("CPP_Example_WebSocket", "apache", "dev@trafficserver.apache.org");
- new WebSocketInstaller();
+ plugin = new WebSocketInstaller(); // We keep a pointer to this so that clang-analyzer doesn't think it's a leak
}
// WebSocketInstaller
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.
[trafficserver] 02/03: TS-4699: Fix CID 1363288
Posted by so...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
sorber pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git
commit ec4a19aa8b2468d5be65ab77283d8e6f2c1aa657
Author: Phil Sorber <so...@apache.org>
AuthorDate: Wed Sep 28 08:26:01 2016 -0600
TS-4699: Fix CID 1363288
---
lib/atscppapi/examples/websocket/WSBuffer.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/atscppapi/examples/websocket/WSBuffer.cc b/lib/atscppapi/examples/websocket/WSBuffer.cc
index b6aaf41..5cefa34 100644
--- a/lib/atscppapi/examples/websocket/WSBuffer.cc
+++ b/lib/atscppapi/examples/websocket/WSBuffer.cc
@@ -181,7 +181,9 @@ WSBuffer::ws_digest(std::string const &key)
char digest_buf[WS_DIGEST_MAX];
size_t digest_len = 0;
- TSBase64Encode((char *)hash_buf, hash_len, digest_buf, WS_DIGEST_MAX, &digest_len);
+ if (TSBase64Encode((char *)hash_buf, hash_len, digest_buf, WS_DIGEST_MAX, &digest_len) != TS_SUCCESS) {
+ return "base64encode-failed";
+ }
return std::string((char *)digest_buf, digest_len);
}
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.