You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2021/06/27 07:31:18 UTC
[GitHub] [struts] lukaszlenart opened a new pull request #492: [WW-5132] [WW-5123] labelposition - chery-pick
lukaszlenart opened a new pull request #492:
URL: https://github.com/apache/struts/pull/492
Refs [WW-5123](https://issues.apache.org/jira/browse/WW-5123)
Refs [WW-5132](https://issues.apache.org/jira/browse/WW-5132)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] lukaszlenart commented on a change in pull request #492: [WW-5132] [WW-5123] labelposition - cherry-pick
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #492:
URL: https://github.com/apache/struts/pull/492#discussion_r662039295
##########
File path: core/src/main/java/org/apache/struts2/components/UIBean.java
##########
@@ -689,7 +689,9 @@ public void evaluateParams() {
}
if (labelPosition != null) {
- addParameter("labelposition", findString(labelPosition));
+ String labelPosition = findString(this.labelPosition);
+ addParameter("labelposition", labelPosition);
Review comment:
Yet someone can depend on that in his custom theme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] yasserzamani commented on a change in pull request #492: [WW-5132] [WW-5123] labelposition - cherry-pick
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on a change in pull request #492:
URL: https://github.com/apache/struts/pull/492#discussion_r662036628
##########
File path: core/src/main/java/org/apache/struts2/components/UIBean.java
##########
@@ -689,7 +689,9 @@ public void evaluateParams() {
}
if (labelPosition != null) {
- addParameter("labelposition", findString(labelPosition));
+ String labelPosition = findString(this.labelPosition);
+ addParameter("labelposition", labelPosition);
Review comment:
Not sure but I think not required anymore as all usages in all ftl files are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls commented on pull request #492: [WW-5132] [WW-5123] labelposition - cherry-pick
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #492:
URL: https://github.com/apache/struts/pull/492#issuecomment-869118028
[](https://coveralls.io/builds/40910323)
Coverage decreased (-0.002%) to 49.914% when pulling **9e1d4829e57f71a4d85ff12aea9b18638d30d942 on WW-5123-labelposition** into **1567f7699dafc06cc3062b8e9f6f3f7447222c20 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] yasserzamani merged pull request #492: [WW-5132] [WW-5123] labelposition - cherry-pick
Posted by GitBox <gi...@apache.org>.
yasserzamani merged pull request #492:
URL: https://github.com/apache/struts/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org