You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/05/17 19:30:12 UTC
[kudu-CR](branch-1.15.x) [txns] add a means to get transaction metadata from participant
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17467
Change subject: [txns] add a means to get transaction metadata from participant
......................................................................
[txns] add a means to get transaction metadata from participant
This patch adds a GET_METADATA participant RPC and a method to call it
through the TxnSystemClient. The RPC currently returns the TxnMetadataPB
for the given transaction, giving a bit of insight into the state of the
given participant.
I will use this in an upcoming tool that drills into a transaction and
its participants.
Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Reviewed-on: http://gerrit.cloudera.org:8080/17446
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit e5202c0fc04f97d22ea3eb88625d0bd9d86d07f0)
---
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/transactions/participant_rpc.cc
M src/kudu/transactions/participant_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
11 files changed, 232 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/17467/1
--
To view, visit http://gerrit.cloudera.org:8080/17467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17467
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.15.x) [txns] add a means to get transaction metadata from participant
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17467 )
Change subject: [txns] add a means to get transaction metadata from participant
......................................................................
[txns] add a means to get transaction metadata from participant
This patch adds a GET_METADATA participant RPC and a method to call it
through the TxnSystemClient. The RPC currently returns the TxnMetadataPB
for the given transaction, giving a bit of insight into the state of the
given participant.
I will use this in an upcoming tool that drills into a transaction and
its participants.
Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Reviewed-on: http://gerrit.cloudera.org:8080/17446
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/17467
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/transactions/participant_rpc.cc
M src/kudu/transactions/participant_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
11 files changed, 232 insertions(+), 39 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Bankim Bhavsar: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17467
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [txns] add a means to get transaction metadata from participant
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17467 )
Change subject: [txns] add a means to get transaction metadata from participant
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17467
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 May 2021 23:54:15 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [txns] add a means to get transaction metadata from participant
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [txns] add a means to get transaction metadata from participant
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17467
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [txns] add a means to get transaction metadata from participant
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17467 )
Change subject: [txns] add a means to get transaction metadata from participant
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17467
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 May 2021 21:10:49 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [txns] add a means to get transaction metadata from participant
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17467
to look at the new patch set (#2).
Change subject: [txns] add a means to get transaction metadata from participant
......................................................................
[txns] add a means to get transaction metadata from participant
This patch adds a GET_METADATA participant RPC and a method to call it
through the TxnSystemClient. The RPC currently returns the TxnMetadataPB
for the given transaction, giving a bit of insight into the state of the
given participant.
I will use this in an upcoming tool that drills into a transaction and
its participants.
Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Reviewed-on: http://gerrit.cloudera.org:8080/17446
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/transactions/participant_rpc.cc
M src/kudu/transactions/participant_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
11 files changed, 232 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/17467/2
--
To view, visit http://gerrit.cloudera.org:8080/17467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17467
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [txns] add a means to get transaction metadata from participant
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17467 )
Change subject: [txns] add a means to get transaction metadata from participant
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17467
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 19 May 2021 04:38:52 +0000
Gerrit-HasComments: No