You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/06/25 15:51:20 UTC

Review Request 12079: Fix for CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12079/
-----------------------------------------------------------

Review request for cloudstack and Abhinandan Prateek.


Bugs: CLOUDSTACK-2794


Repository: cloudstack-git


Description
-------

CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java fb857a7 
  server/src/com/cloud/configuration/Config.java 3a6d3aa 
  server/src/com/cloud/template/TemplateManagerImpl.java 273614c 
  setup/db/db/schema-410to420.sql d2add32 

Diff: https://reviews.apache.org/r/12079/diff/


Testing
-------

Tested with latest master, also upgrade case.


Thanks,

Harikrishna Patnala


Re: Review Request 12079: Fix for CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12079/#review22399
-----------------------------------------------------------


Commit ec2bf092847a12f0f29c26a01ecfc6add90fedb2 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ec2bf09 ]

CLOUDSTACK-2794: Global parameter "router.template.id" should be removed The parameter was not in use. We use zone/global coonfigutaion parameters router.template.xenserver/vmware/hyperv/kvm/lxc to deploy router

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On June 25, 2013, 1:51 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12079/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 1:51 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-2794
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java fb857a7 
>   server/src/com/cloud/configuration/Config.java 3a6d3aa 
>   server/src/com/cloud/template/TemplateManagerImpl.java 273614c 
>   setup/db/db/schema-410to420.sql d2add32 
> 
> Diff: https://reviews.apache.org/r/12079/diff/
> 
> 
> Testing
> -------
> 
> Tested with latest master, also upgrade case.
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12079: Fix for CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12079/#review22505
-----------------------------------------------------------


Commit 98b47ab4667e57e110faa88a71ce2f78a2161a8b in branch refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=98b47ab ]

CLOUDSTACK-2794: Global parameter "router.template.id" should be removed The parameter was not in use. We use zone/global coonfigutaion parameters router.template.xenserver/vmware/hyperv/kvm/lxc to deploy router

Signed-off-by: Jayapal <ja...@apache.org>


- ASF Subversion and Git Services


On June 25, 2013, 1:51 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12079/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 1:51 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-2794
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java fb857a7 
>   server/src/com/cloud/configuration/Config.java 3a6d3aa 
>   server/src/com/cloud/template/TemplateManagerImpl.java 273614c 
>   setup/db/db/schema-410to420.sql d2add32 
> 
> Diff: https://reviews.apache.org/r/12079/diff/
> 
> 
> Testing
> -------
> 
> Tested with latest master, also upgrade case.
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12079: Fix for CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12079/#review22391
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On June 25, 2013, 1:51 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12079/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 1:51 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-2794
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java fb857a7 
>   server/src/com/cloud/configuration/Config.java 3a6d3aa 
>   server/src/com/cloud/template/TemplateManagerImpl.java 273614c 
>   setup/db/db/schema-410to420.sql d2add32 
> 
> Diff: https://reviews.apache.org/r/12079/diff/
> 
> 
> Testing
> -------
> 
> Tested with latest master, also upgrade case.
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>