You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2016/02/28 15:41:07 UTC

svn commit: r1732744 - in /webservices/axiom/trunk: aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/mixin/AxiomChildNodeSupport.aj implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPBodyImpl.java

Author: veithen
Date: Sun Feb 28 14:41:06 2016
New Revision: 1732744

URL: http://svn.apache.org/viewvc?rev=1732744&view=rev
Log:
There is no good reason for not allowing to detach a SOAPBody from its parent.

Modified:
    webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/mixin/AxiomChildNodeSupport.aj
    webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPBodyImpl.java

Modified: webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/mixin/AxiomChildNodeSupport.aj
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/mixin/AxiomChildNodeSupport.aj?rev=1732744&r1=1732743&r2=1732744&view=diff
==============================================================================
--- webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/mixin/AxiomChildNodeSupport.aj (original)
+++ webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/mixin/AxiomChildNodeSupport.aj Sun Feb 28 14:41:06 2016
@@ -70,7 +70,7 @@ public aspect AxiomChildNodeSupport {
         }
     }
     
-    public OMNode AxiomChildNode.detach() {
+    public final OMNode AxiomChildNode.detach() {
         if (!coreHasParent()) {
             throw new OMException(
                     "Nodes that don't have a parent can not be detached");

Modified: webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPBodyImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPBodyImpl.java?rev=1732744&r1=1732743&r2=1732744&view=diff
==============================================================================
--- webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPBodyImpl.java (original)
+++ webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPBodyImpl.java Sun Feb 28 14:41:06 2016
@@ -21,8 +21,6 @@ package org.apache.axiom.soap.impl.llom;
 
 import org.apache.axiom.om.OMConstants;
 import org.apache.axiom.om.OMElement;
-import org.apache.axiom.om.OMException;
-import org.apache.axiom.om.OMNode;
 import org.apache.axiom.soap.SOAPProcessingException;
 import org.apache.axiom.soap.impl.intf.AxiomSOAPBody;
 
@@ -35,9 +33,4 @@ public abstract class SOAPBodyImpl exten
                     "Expecting an implementation of SOAP Envelope as the parent. But received some other implementation");
         }
     }
-
-    public OMNode detach() throws OMException {
-        throw new SOAPProcessingException(
-                "Can not detach SOAP Body, SOAP Envelope must have a Body !!");
-    }
 }