[GitHub] [flink] zentol commented on a change in pull request #15883: [FLINK-22556][ci] Extend JarFileChecker to search for traces of incompatible licenses

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #15883:
URL: https://github.com/apache/flink/pull/15883#discussion_r629913170



##########
File path: tools/ci/java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java
##########
@@ -188,4 +276,24 @@ private static int getNumLicenseFilesOutsideMetaInfDirectory(Path jar, Path jarR
     private static String getFileName(Path path) {
         return path.getFileName().toString().toLowerCase();
     }
+
+    private static boolean pathStartsWith(Path file, String path) {
+        return file.startsWith(file.getFileSystem().getPath(path));
+    }
+
+    private static boolean equals(Path file, String path) {
+        return file.equals(file.getFileSystem().getPath(path));
+    }
+
+    private static boolean isNoClassFile(Path file) {
+        return !getFileName(file).endsWith(".class");
+    }
+
+    private static boolean isJavaxManifest(Path jar, Path potentialManifestFile) {
+        final String jarFileName = getFileName(jar);
+
+        return (jarFileName.startsWith("flink-s3-fs-hadoop")
+                        || jarFileName.startsWith("flink-s3-fs-presto"))

Review comment:
       they contain it, and I didn't want other modules to also be included because it is not apparent from the file that it is about javax.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org