You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/04 11:30:29 UTC
[GitHub] [shardingsphere] tristaZero opened a new pull request #6618: Add gitignore and optimize proxy backend interface.
tristaZero opened a new pull request #6618:
URL: https://github.com/apache/shardingsphere/pull/6618
Ref #6466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #6618: Add gitignore and optimize proxy backend interface.
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6618:
URL: https://github.com/apache/shardingsphere/pull/6618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6618: Add gitignore and optimize proxy backend interface.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6618:
URL: https://github.com/apache/shardingsphere/pull/6618#discussion_r465401420
##########
File path: .gitignore
##########
@@ -1,5 +1,6 @@
# maven ignore
target/
+gen/
Review comment:
? You suggested to add it to gitignore, didn't you? BTW, it is for code generating from antlr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #6618: Add gitignore and optimize proxy backend interface.
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #6618:
URL: https://github.com/apache/shardingsphere/pull/6618#discussion_r465144952
##########
File path: .gitignore
##########
@@ -1,5 +1,6 @@
# maven ignore
target/
+gen/
Review comment:
What is useful of this folder?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org