[GitHub] [netbeans] Chris2011 commented on pull request #2438: NETBEANS-4893 - Added node_modules and bower_components to the option

[GitBox <gi...@apache.org>]

Chris2011 commented on pull request #2438:
URL: https://github.com/apache/netbeans/pull/2438#issuecomment-706742979


   @matthiasblaesing unfortunately you are right. But what speaks against it is the following case:
   
   I have 5 - 6 Web projects open (next to a lot of others, web independent projects).
   One project is the biggest, that I'm working on, it is from my company. The node_modules folder has 115.605 files and 18.964 folders. The node_modules folder is 963 mb big. It is a mono repo with nrwl-nx - Angular application. After I removed the node_modules from the ignored files pattern, NetBeans started indexing. This project, needed round about 1h to finish and the web projects needed round about 1 more hour. So all in all it ~ 2h for indexing/background scanning the node_modules folder. Which seems waaaaaay to long.
   
   My environment is a Surface Laptop 3, Windows 10, latest version with an i7, 16GB RAM and a M2 SSD. Afaik, not even Windows need that much time to indexing 100k files. I know this is another case but there is also another application called everything: https://en.wikipedia.org/wiki/Everything_(software) It took round about 30s - 1m to index the whole SSD with 3.638.195 files on it. It is written in C/C++ and assembler. Just to let you know, that I don't understand, why NetBeans took so long so as you see it gets faster. Btw Windows Defender is disabled, so this can't be the problem.
   
   So long story short, whether there is possible to be as fast as the everything tool, which would be pretty awesome in any case and second, if not possible my solution for indexing the node_modules would be to read out all packages from the package.json and bower.json, that should be fast enough I guess. Also, indexing all modules, that are used by require() and the ES 6 modules with import etc. So that would be a good improvement to still have code completion for all imported modules and maybe sub modules like incrementialy index.
   
   Is one of those solutions possible? IMHO, it is not needed to index all files in node_modules. Or someone knows how VS Code and WebStorm does it. WebStorm is also fast enough for my point of view. It just needed ~2min to index the company project which is quite good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists