You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/08/02 09:35:35 UTC

[GitHub] [incubator-pekko] He-Pin opened a new issue, #526: Make org.apache.pekko.actor.AbstractActor#preRestart final

He-Pin opened a new issue, #526:
URL: https://github.com/apache/incubator-pekko/issues/526

   >TODO In Pekko 1.1.0, we can remove deprecation and make the method final
   
   ```scala
     // TODO In Pekko 1.1.0, we can remove deprecation and make the method final
     @deprecated("Override preRestart with message parameter with Optional type instead", "Akka 2.5.0")
     @throws(classOf[Exception])
     @nowarn("msg=deprecated")
     override def preRestart(reason: Throwable, message: Option[Any]): Unit = {
       import pekko.util.OptionConverters._
       preRestart(reason, message.toJava)
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko] pjfanning commented on issue #526: Make org.apache.pekko.actor.AbstractActor#preRestart final

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #526:
URL: https://github.com/apache/incubator-pekko/issues/526#issuecomment-1662119699

   @He-Pin why not remove it altogether?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org