[jira] [Commented] (TS-2912) HEAD transaction on stale entry deletes cache entry

["William Bardwell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083252#comment-14083252 ] 

William Bardwell commented on TS-2912:
--------------------------------------

Why did you want it to add If-Modified-Since or If-None-Match if the request is a HEAD request?
The chnge to request_conditional seems reasonable, but not sure that it will fix it, it seems like handle_cache_operation_on_forward_server_response() needs to not delete things...

> HEAD transaction on stale entry deletes cache entry
> ---------------------------------------------------
>
>                 Key: TS-2912
>                 URL: https://issues.apache.org/jira/browse/TS-2912
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: William Bardwell
>            Assignee: weijin
>              Labels: review
>             Fix For: 5.1.0
>
>         Attachments: ts-2912.try1.diff
>
>
> On a stale cache entry a HEAD gets tunneled to the origin, but when a 200 comes back HttpTransact::handle_cache_operation_on_forward_server_response(State* s)
> deletes the cache entry, it seems like it should just ignore it (or check ETag/Last-Modified and maybe delete if those don't match, but not unconditionally.)
> I am seeing this with 4.2.X with a plugin fiddling with stuff, but the code looks the same in trunk, line 4318 looks like the problem line.



--
This message was sent by Atlassian JIRA
(v6.2#6252)