You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2019/09/25 19:14:23 UTC
[zeppelin] branch master updated: [ZEPPELIN-4280] Fix an issue that
makes an infinite loop while switching the visualizations
This is an automated email from the ASF dual-hosted git repository.
moon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new be7ace1 [ZEPPELIN-4280] Fix an issue that makes an infinite loop while switching the visualizations
be7ace1 is described below
commit be7ace1f5e84c7a5989b4d5882cbf759de34112d
Author: Jaewon Seo <ja...@zepl.com>
AuthorDate: Thu Jul 25 17:00:00 2019 -0700
[ZEPPELIN-4280] Fix an issue that makes an infinite loop while switching the visualizations
### What is this PR for?
Fix an issue that makes an infinite loop while switching the visualizations.
An infinite loop occurs because the front-end web application tries to commit the paragraph even if there are no changes in the visualization configuration.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4280
### How should this be tested?
If you switch quickly between different visualizations multiple times, the infinite loops should not happen.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jaewon Seo <ja...@zepl.com>
Closes #3414 from Byeol/ZEPPELIN-4280 and squashes the following commits:
d49d36ac1 [Jaewon Seo] Commit the paragraph only if there are changes in the visualization configuration
---
zeppelin-web/src/app/notebook/paragraph/result/result.controller.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
index f4e5b82..97372e2 100644
--- a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
@@ -812,6 +812,9 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams, $location
newConfig.graph.values = newConfig.graph.commonSetting.pivot.values;
delete newConfig.graph.commonSetting.pivot;
}
+ if (angular.equals($scope.config, newConfig)) {
+ return;
+ }
console.debug('committVizConfig', newConfig);
let newParams = angular.copy(paragraph.settings.params);
commitParagraphResult(paragraph.title, paragraph.text, newConfig, newParams);