[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #4419: HDFS-16627. improve BPServiceActor#register Log Add NN Addr.

[GitBox <gi...@apache.org>]

Hexiaoqiao commented on code in PR #4419:
URL: https://github.com/apache/hadoop/pull/4419#discussion_r893570312


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java:
##########
@@ -816,7 +816,7 @@ void register(NamespaceInfo nsInfo) throws IOException {
     // off disk - so update the bpRegistration object from that info
     DatanodeRegistration newBpRegistration = bpos.createRegistration();
 
-    LOG.info(this + " beginning handshake with NN");
+    LOG.info("{} beginning handshake with NN:{}", this, nnAddr);

Review Comment:
   Please keep the same format of log, such as delete the blank at end of a sentence, leave one blank between two words. such as,
   L819: `LOG.info("{} beginning handshake with NN: {}", this, nnAddr);`
   L831: `LOG.info("Problem connecting to server: {}", nnAddr);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org