[GitHub] [hbase] Apache9 commented on a change in pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #1991:
URL: https://github.com/apache/hbase/pull/1991#discussion_r449781947



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java
##########
@@ -497,7 +497,7 @@ public void run(MultiResponse resp) {
                     "Failed to mutate row: " + Bytes.toStringBinary(mutation.getRow()), ex));
               } else {
                 future.complete(respConverter
-                  .apply((Result) multiResp.getResults().get(regionName).result.get(0)));
+                  .apply((RES) multiResp.getResults().get(regionName).result.get(0)));

Review comment:
       OK, so the problem here is that, the result for a multi operation is an Object? And we will have two types, one is Result, for normal mutateRow, and the other is CheckAndMutateResult, for checkAndMutate?

##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableOverAsyncTable.java
##########
@@ -300,13 +300,16 @@ public boolean thenMutate(RowMutations mutation) throws IOException {
   }
 
   @Override
-  public boolean checkAndMutate(CheckAndMutate checkAndMutate) throws IOException {
+  public CheckAndMutateResult checkAndMutate(CheckAndMutate checkAndMutate) throws IOException {
     return FutureUtils.get(table.checkAndMutate(checkAndMutate));
   }
 
   @Override
-  public boolean[] checkAndMutate(List<CheckAndMutate> checkAndMutates) throws IOException {
-    return Booleans.toArray(FutureUtils.get(table.checkAndMutateAll(checkAndMutates)));
+  public CheckAndMutateResult[] checkAndMutate(List<CheckAndMutate> checkAndMutates)

Review comment:
       Better to return a List?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org